<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Marko,<br><br>the patch looks good to me.<br>Typically there are only a few hundred relations in one tile, so I do not expect <br>a big change in performance if we don't create objects for the very few <br>relations that we don't supprt.<br>I think it is ok to ignore the restriction, because we have no other code to interpret it.<br><br>Gerd<br> <br><div>Date: Thu, 2 Jan 2014 19:37:28 +0200<br>From: marko.makela@iki.fi<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: [mkgmap-dev] [PATCH] Do not create RestrictionRelation for unspecified restriction<br><br><pre>There are a few restriction relations for "no through route" mapped in <br>Finland. These are a bit ambiguous, because it looks like there are <br>multiple possible routes, all of which are banned. These relations are <br>tagged with type=restriction, but not with any restriction=*.<br> <br>For mkgmap, the issue is that multiple warnings get emitted for the <br>single relation. The attached patch would emit just one warning, for the <br>restriction=* being missing. OK to commit?<br> <br>(Side note: I think that it could be better if there was a "factory" <br>method that created the RestrictionRelation if it is supported. It seems <br>to be a waste of memory to create a RestrictionRelation object that we <br>do not support, for example when there are via ways instead of via <br>nodes.)<br> <br>While working on this, I was wondering why we set rel=null if turn <br>restrictions are being ignored. I think that the relation should be <br>collected, just like any relation that does not have any magic meaning, <br>so that any style rules could process the relation. I did not touch that <br>part of the code.<br> <br>Best regards,<br> <br> Marko<br></pre><br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>