<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Steve,<br><br>the major error was caused by a last minute change, another one by wrong masking.<br>Please check attached v2 of the patch. I still see error messages regarding ratio and <br>bearing, but they may be caused by the different precisions.<br>How sure are you about these threshold values in NodCheck?<br> double v = 30.0;<br> int calcRatio = (int) Math.round(v * direct / path) & 0x1f;<br> if (calcRatio > 26)<br> calcRatio = 0;<br><br>Gerd<br><br><div><hr id="stopSpelling">From: gpetermann_muenchen@hotmail.com<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Date: Wed, 12 Feb 2014 14:39:21 +0100<br>Subject: Re: [mkgmap-dev] [Patch v1] curve bytes<br><br>
<style><!--
.ExternalClass .ecxhmmessage P {
padding:0px;
}
.ExternalClass body.ecxhmmessage {
font-size:12pt;
font-family:Calibri;
}
--></style>
<div dir="ltr">Hi Steve,<br><br>yes, I just found this as well. The remaining errors all have ratio = 7, looking at this now.<br><br>Gerd<br><br><div>> Date: Wed, 12 Feb 2014 13:37:43 +0000<br>> From: steve@parabola.me.uk<br>> To: mkgmap-dev@lists.mkgmap.org.uk<br>> Subject: Re: [mkgmap-dev] [Patch v1] curve bytes<br>> <br>> On 12/02/14 10:46, Gerd Petermann wrote:<br>> > @@ -80,22 +88,27 @@<br>> > this.roadDef = roadDef;<br>> > this.source = source;<br>> > this.dest = dest;<br>> > - this.initialHeading = initialHeading;<br>> > - this.finalHeading = finalHeading;<br>> > - this.length = convertMeters(length);<br>> > + this.initialHeading = (float) initialBearing;<br>> > + this.finalHeading = (float) finalBearing;<br>> > + this.directHeading = (float) directBearing;<br>> > + this.length = convertMeters(length);<br>> > this.curveEnabled = curveEnabled;<br>> > this.pointsHash = pointsHash;<br>> > + int encodedDirectLength = convertMeters(source.getCoord().distance(dest.getCoord()));<br>> > + <br>> > + lengthRatio = (byte) ((int)Math.round(32.0 * encodedDirectLength / length) & 0x1f);<br>> <br>> This (above) should use this.length, not length<br>> <br>> > + haveCurve = curveEnabled && lengthRatio > 0;<br>> > }<br>> <br>> That fix makes leaves me with just a small number of ratio errors.<br>> <br>> ..Steve<br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br></div> </div>
<br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>