<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi,<br><br>I've committed three of five patches.<br><br>1) I think there is no need to change the default for option name-tag-list from "name" to "name,place_name",<br>but I would not mind to do it.<br><br>2) Reg. the patch for RuleFileReader:<br>I leave that to Steve or WanMil. I think it can be configured in the logging.properties as well.<br><br>Gerd<br><br><br><br><div><hr id="stopSpelling">Date: Mon, 10 Nov 2014 14:11:21 +0100<br>From: ben@bagu.org<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: Re: [mkgmap-dev] patches<br><br><div dir="ltr">Hi Brian,<br><br>Thanks for the feedback.<br><div><div class="ecxgmail_extra"><br><div class="ecxgmail_quote">On Thu, Nov 6, 2014 at 3:13 AM, Brian Egge <span dir="ltr"><<a href="mailto:brianegge@gmail.com" target="_blank">brianegge@gmail.com</a>></span> wrote:<br></div><div class="ecxgmail_quote"><snip><br></div><div class="ecxgmail_quote"><blockquote class="ecxgmail_quote" style="border-left:1px solid rgb(204,204,204);padding-left:1ex;"><div style="word-wrap:break-word;"><div>The NYC addresses are working well. I have a minor correction as follows:</div><div><br></div><div><div>Index: resources/styles/default/inc/address</div><div>===================================================================</div><div>--- resources/styles/default/inc/address<span style="white-space:pre-wrap;"> </span>(revision 3342)</div><div>+++ resources/styles/default/inc/address<span style="white-space:pre-wrap;"> </span>(working copy)</div><div>@@ -66,8 +66,11 @@</div><div> # New York City has different admin levels than the rest of the US.</div><div> # <a href="https://wiki.openstreetmap.org/wiki/United_States_admin_level" target="_blank">https://wiki.openstreetmap.org/wiki/United_States_admin_level</a></div><div> mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='New York County' { set mkgmap:city='New York' }</div><div>-mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Bronx County' { set mkgmap:city='The Bronx' }</div><div>+mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Bronx County' { set mkgmap:city='Bronx' }</div><div> mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Kings County' { set mkgmap:city='Brooklyn' }</div><div>+# Queens uses neighborhoods for city in postal addresses</div><div>+# <a href="http://en.wikipedia.org/wiki/List_of_Queens_neighborhoods" target="_blank">http://en.wikipedia.org/wiki/List_of_Queens_neighborhoods</a></div><div>+mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Queens County' & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8}' }</div><div> mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Queens County' { set mkgmap:city='Queens' }</div><div> mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level5='New York City' & mkgmap:admin_level6='Richmond County' { set mkgmap:city='Staten Island' }</div><div> mkgmap:country=USA & mkgmap:city!=* & mkgmap:admin_level8=* { set mkgmap:city='${mkgmap:admin_level8|subst:City of }’ }</div></div><div><br></div><div>One always says ‘The Bronx’, but in addresses is it’s simply Bronx. For Queens, the neighborhood is used in mailing addresses, though sometimes people will use ‘Queens’ instead. If you look up "40-01 43 AVENUE” <a href="http://www.usps.com" target="_blank">www.usps.com</a>, it says the standardized address is:</div><div>4001 43RD AVE<br>SUNNYSIDE NY 11104-3205</div><div><br></div><div>But, the <a href="http://schools.nyc.gov/SchoolPortals/30/Q150/default.htm" target="_blank">school board</a> lists it’s address as:</div><div>40-01 43 AVENUE<br>QUEENS, NY11104</div><div><br></div><div>While the <a href="https://sites.google.com/site/ps150queens/" target="_blank">school itself</a> says it’s address is:</div><div>40-01 43 Avenue Sunnyside, NY 11104</div><div><br></div><div>If I’m given an address, most likely it will have the neighborhood in it, and not ‘Queens’. </div></div></blockquote><div><br></div><div>I briefly looked into this as well and you are correct. Good catch, thanks. <br><br>@Gerd (or other mkgmap developers): Can you update the address rules for NYC with Brian's patch. Thanks.<br></div><div><br></div><blockquote class="ecxgmail_quote" style="border-left:1px solid rgb(204,204,204);padding-left:1ex;"><div style="word-wrap:break-word;"><div>Here’s an alternative patch to pick up place_name:</div><div><div>Index: src/uk/me/parabola/mkgmap/build/LocatorUtil.java</div><div>===================================================================</div><div>--- src/uk/me/parabola/mkgmap/build/LocatorUtil.java<span style="white-space:pre-wrap;"> </span>(revision 3342)</div><div>+++ src/uk/me/parabola/mkgmap/build/LocatorUtil.java<span style="white-space:pre-wrap;"> </span>(working copy)</div><div>@@ -28,7 +28,7 @@</div><div> <span style="white-space:pre-wrap;"> </span>.compile("[,<a target="_blank">\\s</a>]+");</div><div> <span style="white-space:pre-wrap;"> </span></div><div> <span style="white-space:pre-wrap;"> </span>public static List<String> getNameTags(Properties props) {</div><div>-<span style="white-space:pre-wrap;"> </span>String nameTagProp = props.getProperty("name-tag-list", "name");</div><div>+<span style="white-space:pre-wrap;"> </span>String nameTagProp = props.getProperty("name-tag-list", "name,place_name");</div><div> <span style="white-space:pre-wrap;"> </span>return Arrays.asList(COMMA_OR_SPACE_PATTERN.split(nameTagProp));</div><div> <span style="white-space:pre-wrap;"> </span>}</div></div></div></blockquote><div><br></div><div>I think it makes sense to have this in mkgmap. Personally I prefer the patch which displays a warning message so that I can include it in the list of warnings to fix on my website. But I guess the mkgmap developers are in the best position to decide which is best. If this solution is chosen, a comment would be useful - maybe just indicate that 'place_name' is only included for compatibility with an old tag. Perhaps place_name would be removed in the future when it's no longer in OSM.<br></div><div> <br></div><div>Your other patches seem ok to me but I'm probably not the best person to review them. :)<br><br>Thanks again for this work.<br><br></div><div>Ben<br> </div></div></div></div></div>
<br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>