<html>
<head>
</head>
<body class='hmmessage'><div dir='ltr'>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style>
<div dir="ltr">Hi all,<br><br>this point is on the to do list, but I am not sure what the target is.<br>I guess it should replace the two options drive-on-right and drive-on-left.<br>("dor","dol")<br><br>A possible implementation looks like this:<br>1) add property driveOnLeft="true" to the appropriate countries in LocatorConfig.xml<br>2) add methods to lookup the property for a given roundabout<br>3) count the number of "dol" and "dor" roundabouts<br>4) If neither the --drive-on-left option or --drive-on-right option is set, use the counters:<br>if the "dol" number is larger than the "dor" number,<br>set the "dol" flag in the NOD header to 1.<br><br>So far so easy. I guess in most usage cases one of the counters is 0 and the other is not,<br>so that would work fine.<br><br>Open questions:<br>1) What should happen for those tiles containing both "dol" and "dor" roundabouts?<br>2) What should happen if the --drive-on-left option is given and the tile contains<br>only "dor" roundabouts (or vice-versa) ? Should we ignore the option given by the user<br>and print a corresponding warning?<br>3) We have the --check-roundabouts option which also might set the flag in the NOD header<br>if the user doesn't specify --drive-on-left or --drive-on-right. The current implementation<br>simply uses the direction of first roundabout (clockwise or not) to decide which driving side<br>is to be used and it reverses the direction of all following roundabouts which don't match<br>the direction of the first one. I assume this should be changed so that we use the above counters<br>as well?<br><br><br>@Steve:<br>The data in the LocatorConfig.xml seems to be only used in combination with the --bounds<br>option, without precompiled bounds the default style will not set mkgmap:country which is used<br>to get the data from the LocatorConfig.xml. I did expect that an option like --country-name or --country-abbr <br>could be used to set a default, and the code really passes the values to a method in Locator <br>called setDefaultCountry(), but that method is only adding /overwriting a HashMap of country-name+iso-code<br>which is filled from LocatorConfig.xml .<br>Is that intended?<br><br><br><br><br><br><br><br><br><br><br><br></div>
</div></body>
</html>