<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Andrzej,<br><br>> I have assumed, that option --check-roundabout gets a new algorithm, the <br><div>> one that you have described. I would prefer that use of "dol/dor" <br>> counting was controlled by user and option --check-roundabouts looks <br>> prefect for this purpose.<br>The counting is simple and needs only only a few HashMap lookups.<br>The question is what we do with the values.<br><br>> <br>> I think that flags in IMG should be consistent, the one you have <br>> mentioned in NOD and a flag in TRE. So any decision about <br>> drive-on-left/right should be taken once and should force setting of <br>> both flags.<br><br>Ah, I did not think about TRE header until now.<br>BTW: The current implementation in trunk <br>sets the flag in the TRE header only if option drive-on-left<br>is set, it ignores the results of the check-roundabout option.<br><br>> <br>> My idea is that user can select following processing:<br>> <br>> - Automatic detection of left/right by using --check-roundabout with <br>> options --drive-on-left/right as a fallback.<br>> <br>> - Forced setting with option --drive-on-left/right alone.<br>> <br>> - Default setting when no options are used. Defaults could be taken from <br>> LocatorConfig.xml or simply set as drive-on-right (hope this is more <br>> common).<br>> <br>> This description also defines priority of processing, with "dol/dor" <br>> counting as a first choice, but only if user set explicit option.<br><br>I am not sure if you understand what check-roundabouts is doing.<br>It determines whether a roundabout is clockwise or not<br>and changes the order if it doesn't match. The first roundabout<br>is used to find out if left or right is correct. The test data contains<br>a few cases where roundabouts in the UK have the wrong direction,<br>I don't know if this is still the case.<br>So, in my eyes the user sets check-roundabouts to make sure<br>that all round-abouts are either clockwise or ccw, and<br>he uses --drive-on-left or --drive-on-right to avoid the weak auto-detection.<br><br>Gerd<br></div> </div></body>
</html>