<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi all,<br><br>attached is 2nd version of the patch. Steves test showed an error in my 1st patch.<br>I've also added tests for the part function.<br><br>I noticed that it is currently not possible to use ":" as a separator in the part style function.<br>Seems not to be needed?<br><br>Gerd<br><br><div>Date: Tue, 16 Dec 2014 09:22:05 +0000<br>From: steve@parabola.me.uk<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: Re: [mkgmap-dev] [Patch v1] check length in substring style function<br><br><pre>Hi Gerd<br> <br>> I forgot to answer this post from gbbickerton:<br>> "May i suggest that a test is made to check that the string is long<br>> enough before applying this filter otherwise an exception occurs .It<br>> would be unsafe to use this filter in any style without such a test. "<br> <br>Well remembered, thanks.<br> <br>It could also do with some tests, I've attached some.<br> <br>I would like to use SyntaxException instead of ExitException for<br>all cases where an error can be detected at compile time<br>in a style file.<br> <br>I realise that ExitException was already used in that class.<br>PartFilter is the only other example I can see where it does<br>not use SyntaxException.<br> <br>..Steve<br> <br></pre><br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>