<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Steve,<br><br>reg. the failed test:<br>I think you can change the test because StyledConverter doesn't do<br>this (at least not now). <br>If you think it should be working we would need a method to<br>reset the field "current" in all LinkedOps so that they are evaluated again<br>for the same Element instance.<br><br>Gerd <br><br><br><div>Date: Mon, 2 Feb 2015 23:26:09 +0000<br>From: steve@parabola.me.uk<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: Re: [mkgmap-dev] [Patch v1] avoid duplicate evaluation of rules<br><br><pre>Hi<br> <br>I found a place in the code which only dealt with a single OR. Changing<br>that to deal with any number seems to fix the problem.<br> <br>There is however a problem that a test fails. It does not appear to<br>be directly related to the fix, since it only occurs when resolving<br>the same way with different (changed) tags against the same<br>rule set. That needs more investigation.<br> <br>Patch attached, and jar here: <br><a href="http://files.mkgmap.org.uk/download/247/mkgmap.jar" target="_blank">http://files.mkgmap.org.uk/download/247/mkgmap.jar</a><br> <br> <br>> as A drian pointed out here:<br>><br>> <a href="http://gis.19327.n5.nabble.com/Bug-in-handling-of-bus-stops-tp5832099.html" target="_blank">http://gis.19327.n5.nabble.com/Bug-in-handling-of-bus-stops-tp5832099.html</a><br>><br>> we have a bug in the style evaluation system. The attached patch<br>> makes sure that each rule is only evaluated once for one element.<br>> If I got it right the problem occurs with rules that combine two<br>> "or" expressions, like<br>> (a | b) & ( c | d) { do something }<br>><br>> A binary based on r3436 is here:<br>> |<a href="http://files.mkgmap.org.uk/download/244/mkgmap.jar" target="_blank">http://files.mkgmap.org.uk/download/244/mkgmap.jar</a><br>> |<br>> @Steve: Please review, I've added a new field "matched" to<br>> WatchableTypeResult<br>> but I think the field "found" was already intended for this?<br>> Maybe you find a better place to fix this?<br>><br>> Gerd<br>><br>><br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>><br> <br></pre><br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>