<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Steve,<br><br>I was surprised to see that these values are written.<br>I've assumed that NONE means something like<br>"don't try to read start and end" to safe some bits,<br>but it seems the values are written (and read) and because of our<br>tests we want to (have to) be able to distinguish between <br>N,0,0 and N,-1,-1 .<br>Well, I can change the patch so that a null pointer means<br>"N,0,0" so that we don't have to waste memory for that default.<br>I did not yet try to find out if there is a best value regarding the<br>number of bits.<br><br>Gerd<br><br><div><hr id="stopSpelling">From: steve@parabola.me.uk<br>Date: Tue, 21 Apr 2015 11:04:04 +0100<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: Re: [mkgmap-dev] error in NumberPreparer?<br><br><style><!--
.ExternalClass .ecxhmmessage P {
padding:0px;
}
.ExternalClass body.ecxhmmessage {
font-size:12pt;
font-family:Calibri;
}
--></style>Hi Gerd<BR>
The -1 is used by convention in the Polish format. It doesn't have any meaning to the img format itself.<br>
<BR>
<br><br><div class="ecxgmail_quote">On 21 April 2015 10:36:32 GMT+01:00, Gerd Petermann <gpetermann_muenchen@hotmail.com> wrote:<blockquote class="ecxgmail_quote" style="border-left:1px solid rgb(204, 204, 204);padding-left:1ex;">
<div dir="ltr">Hi Steve,<br><br>thanks, <br>problem occurs when one side has NONE and the other hasn't.<br>I think the test should not produce values which the normal<br>program never does (NONE with -1 for start + end).<br>Or do you find such data in Garmin maps?<br>In that case meaby it has a special meaning?<br><br>Gerd<br><br><br><div>> Date: Tue, 21 Apr 2015 10:24:47 +0100<br>> From: steve@parabola.me.uk<br>> To: mkgmap-dev@lists.mkgmap.org.uk<br>> Subject: Re: [mkgmap-dev] error in NumberPreparer?<br>> <br>> <br>> Hi Gerd<br>> <br>> > it seems that NumberPreparer (in trunk) doesn't completely ignore<br>> > the start/end values when numberStyle == NONE.<br>> <br>> I was just going to post that the patch failed with NumberRangeTest,<br>> wheras trunk passes. It seems you may have found the answer but I<br>> don't think this code should be reached when both styles are N
ONE<br>> since it should have exited at numbers.isEmpty() -- at least in the<br>> original code.<br>> <br>> > See line 116:<br>> > if (first.getLeftStart() > first.getLeftEnd() ||<br>> > first.getRightStart() > first.getRightEnd())<br>> > initial = Math.max(initial, rightStart);<br>> > else if (rightStart > 0)<br>> > initial = Math.min(initial, rightStart);<br>> <br>> I've got to go out now, I will try to have a look at it later.<br>> <br>> ..Steve<br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br></div> </div>
<p style="border-bottom:1px solid #000;"></p><pre class="ecxk9mail"><hr><br>mkgmap-dev mailing list<br>mkgmap-dev@lists.mkgmap.org.uk<br><a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a></pre></blockquote></div><br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>