<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Steve,<br><br>I think that means that the current code is not correct.<br>HousenumberGenerator may create Numbers with<br>O,1,x,N,0,0<br>When I change Numbers to set default -1 for the start and end<br>values the resulting img file changes and NetDisplay followed by grep Numbers<br>shows different numbers, e.g.<br> | | | Numbers 43,O,1,1,N,-1,-1<br> | | | Numbers 44,N,-1,-1,E,36,36<br>instead of the trunk result:<br><br> | | | Numbers 43,O<b>,-31,-31,</b>N,-1,-1<br> | | | Numbers 44,N,-1,-1,<b>E,6,4</b><br><br>Besides that the img file with defaults -1 is a bit smaller, so I think<br>we should change that in trunk (with the attached patch)<br><br>Gerd<br><br><br><div>> Date: Wed, 22 Apr 2015 00:06:56 +0100<br>> From: steve@parabola.me.uk<br>> To: mkgmap-dev@lists.mkgmap.org.uk<br>> Subject: Re: [mkgmap-dev] error in NumberPreparer?<br>> <br>> Hi Gerd<br>> <br>> > In normal processing, the fields are 0 when style is NONE,<br>> > but NumberRangeTest.java sets them to -1 and this really produces different<br>> > bit streams in some cases, e.g. when iter == 306<br>> > the following test case is generated:<br>> > [0,O,9,7,O,7,5, 1,B,8,2,O,3,5, 2,O,1,1,N,-1,-1]<br>> <br>> I had time to look into this. The ones that go wrong are where there<br>> is 'O' on the left beginning with 1, and 'N' on the right.<br>> As in your example above.<br>> <br>> It turns out that using -1 as the default value of getRightStart()<br>> is required or else the value of zero must be treated specially<br>> in equalizeBases() by adding 'if (right.targetStart == 0) return false;'<br>> <br>> ..Steve<br>> <br>> _______________________________________________<br>> mkgmap-dev mailing list<br>> mkgmap-dev@lists.mkgmap.org.uk<br>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev<br></div> </div></body>
</html>