<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Dave,<br><br>the patch changes the rules in the default style so that exist on primary roads are taken <br>into account. <br>More important for your test case: It also changes the code so that<br>exists on motorway_links to other motorway_links are taken into account.<br>The old code only looked at exits on highway=motorway and highway=trunk,<br>the new code checks these highway types:<br>"motorway", "trunk", "primary", "motorway_link", "trunk_link", "primary_link"<br><br>So, when you use the patched binary with your own style, the big change is that the <br>condition<br>(highway=motorway_link | highway=trunk_link) & mkgmap:exit_hint=true & mkgmap:dest_hint=true<br><br>is now true, and that's why echotags is executed.<br><br>You can double check by adding this rule to your lines file:<br>(mkgmap:exit_hint=* | mkgmap:dest_hint=*) { echotags "hint" }<br><br>Test this once with the patched binary and once with the normal one and you should<br>see the difference.<br><br>Gerd<br><br><div><hr id="stopSpelling">From: daveswarthout@gmail.com<br>Date: Tue, 19 May 2015 18:37:26 -0700<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Subject: Re: [mkgmap-dev] [Patch v1] improve handling of exits<br><br><div dir="ltr">When you say you didn't change the echotags code, did you rewrite the style rule? If you did that I'm embarrassed to admit I am unable to see the difference. <div><br></div><div>AFAIK I'm using the exact same style file for both runs, but the run with the older executables produced no output. I replaced that jar file with the new one (modified r3598) and all of a sudden output from echotags appeared.</div><div><br></div><div>Anyway, it's all good.</div><div><br></div><div><br></div></div><div class="ecxgmail_extra"><br><div class="ecxgmail_quote">On Tue, May 19, 2015 at 11:03 AM, GerdP <span dir="ltr"><<a href="mailto:gpetermann_muenchen@hotmail.com" target="_blank">gpetermann_muenchen@hotmail.com</a>></span> wrote:<br><blockquote class="ecxgmail_quote" style="border-left:1px #ccc solid;padding-left:1ex;">Hi Dave,<br>
<br>
I am not sure if you understand that echotags always worked.<br>
The problem is/was that the rule was not executed because<br>
the expression evaluated to false.<br>
In other words, I did not change the echotags code,<br>
I changed the code so that it is more likely that the<br>
term "mkgmap:exit_hint=true & mkgmap:dest_hint=true"<br>
evaluates to true.<br>
<br>
Gerd<br>
<br>
<br>
Dave Swarthout wrote<br>
<span>> On Mon, May 18, 2015 at 7:51 AM, Gerd Petermann <<br>
<br>
> gpetermann_muenchen@<br>
<br>
</span><span>>> wrote:<br>
><br>
><br>
>> @Dave: Please note the changes in the default style.<br>
>> It would be great if you could test this patch and maybe suggest<br>
>> a better description of the two options.<br>
>><br>
><br>
> Sorry for the delay in responding. The modified r3598 produced output from<br>
> the echotags function. I did not see anything regarding the exit_to tags<br>
> but my test destination tag was processed and this output went to stderr:<br>
><br>
> 4611686018427392234 (168231839) -<br>
> [highway=motorway_link,destination=Beltline Road<br>
> East,mkgmap:exit_hint=true,mkgmap:dest_hint=true,bicycle=yes,mkgmap:way-has-pois=true,mkgmap:exit_hint_ref=195A,mkgmap:label:1=Dest:<br>
> Beltline Road East,oneway=yes] before<br>
> 4611686018427392234 (168231839) -<br>
> [highway=motorway_link,destination=Beltline Road<br>
> East,mkgmap:exit_hint=true,mkgmap:dest_hint=true,bicycle=yes,mkgmap:way-has-pois=true,mkgmap:exit_hint_ref=195A,mkgmap:label:1=Dest:<br>
> Beltline Road East,oneway=yes] after<br>
><br>
</span>> *(highway=motorway_link | highway=trunk_link) & mkgmap:exit_hint=true &*<br>
> *mkgmap:dest_hint=true*<br>
> * { echotags "before";*<br>
> *name '${destination:ref|subst: =>} ${destination|subst:;=> |subst:/=> }'<br>
> |*<br>
> * '${ref|subst: =>} ${destination|subst:;=> |subst:/=> }' |*<br>
> * '${destination|subst:;=> |subst:/=> }' |*<br>
> * 'Exit ${mkgmap:exit_hint_ref} ${mkgmap:exit_hint_name}' |*<br>
> * 'Exit ${mkgmap:exit_hint_ref} ${mkgmap:exit_hint_exit_to}' |*<br>
> * 'Exit ${mkgmap:exit_hint_exit_to}' |*<br>
> * 'Exit ${mkgmap:exit_hint_name}' |*<br>
> * 'Exit ${mkgmap:exit_hint_ref}' ;*<br>
> *echotags "after"*<br>
> * }*<br>
<span>><br>
> This is my rule for debugging the destination tag and it appears before<br>
> the<br>
> rule above:<br>
><br>
</span>> *destination=* & (highway=motorway_link | highway=trunk_link) {name 'Dest:<br>
> ${destination}' }*<br>
<span>><br>
> My exit_to rule is for points is here:<br>
><br>
</span>> *exit_to=* {name 'Exit ${ref} ${exit_to}' | '${exit_to}' } [0x12615<br>
> resolution 24]*<br>
<span>><br>
> This produces the desired output on my maps but doesn't show up in stderr<br>
> because I haven't yet put echotags into my points style file.<br>
><br>
> Thanks for the good work....<br>
><br>
><br>
><br>
><br>
><br>
> --<br>
> Dave Swarthout<br>
> Homer, Alaska<br>
> Chiang Mai, Thailand<br>
> Travel Blog at <a href="http://dswarthout.blogspot.com" target="_blank">http://dswarthout.blogspot.com</a><br>
><br>
</span>> _______________________________________________<br>
> mkgmap-dev mailing list<br>
<br>
> mkgmap-dev@.org<br>
<br>
> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
<br>
<br>
<br>
<br>
<br>
--<br>
View this message in context: <a href="http://gis.19327.n5.nabble.com/Patch-v1-improve-handling-of-exits-tp5845035p5845192.html" target="_blank">http://gis.19327.n5.nabble.com/Patch-v1-improve-handling-of-exits-tp5845035p5845192.html</a><br>
Sent from the Mkgmap Development mailing list archive at Nabble.com.<br>
<div class="ecxHOEnZb"><div class="h5">_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="ecxgmail_signature"><div dir="ltr">Dave Swarthout<br>Homer, Alaska<br>Chiang Mai, Thailand<br>Travel Blog at <a href="http://dswarthout.blogspot.com" target="_blank">http://dswarthout.blogspot.com</a></div></div>
</div>
<br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div> </div></body>
</html>