<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi Marcio,<br><br>I am not sure if I undersstand all arguments correctly, but I think<br>the patch implements what you want. Please try it and let me<br>know when you find problems.<br><br>Gerd<br><br><div><hr id="stopSpelling">From: thundercel@gpsinfo.com.br<br>To: mkgmap-dev@lists.mkgmap.org.uk<br>Date: Thu, 21 May 2015 09:44:48 -0300<br>Subject: Re: [mkgmap-dev] [Patch v2] use role=label member to place POI<br><br>
<style><!--
.ExternalClass .ecxhmmessage P {
padding:0px;
}

.ExternalClass body.ecxhmmessage {
font-size:12pt;
font-family:Calibri;
}

--></style>


<div dir="ltr">
<div style="FONT-SIZE:12pt;FONT-FAMILY:'Calibri';COLOR:#000000;">
<div><span id="ecxresult_box" lang="en"><span class="ecxhps">Hi</span> <span class="ecxhps">Gerd</span><span>,</span><br><span class="ecxhps">our proposal is</span> 
<span class="ecxhps">to always use the</span> <span class="ecxhps">label</span> <span class="ecxhps">node</span> <span class="ecxhps">when that</span> <span class="ecxhps">is 
present</span><span>,</span> <span class="ecxhps">to put the</span> <span class="ecxhps">POI</span> <span class="ecxhps">generated for</span> <span class="ecxhps">admin_level</span> <span class="ecxhps">= 10</span> <span class="ecxhps">limit</span> <span class="ecxhps">when there</span><br><br><span class="ecxhps">I do not know</span> <span class="ecxhps">in other countries,</span> <span class="ecxhps">but in Brazil</span> <span class="ecxhps">we have the</span> <span class="ecxhps">administration</span> <span class="ecxhps">suburb</span> <span class="ecxhps">figure</span> <span class="ecxhps">and usually</span> <span class="ecxhps">that's where</span> <span class="ecxhps">we put the</span> <span class="ecxhps">label</span> <span class="ecxhps">node.</span><br><br><span class="ecxhps">I did 
not understand</span> <span class="ecxhps">your</span> <span class="ecxhps">concern</span> 
<span class="ecxhps">that node</span> <span class="ecxhps">can also be used</span> <span class="ecxhps">for</span> <span class="ecxhps">different</span> <span class="ecxhps">relations</span> <span class="ecxhps">because</span> <span class="ecxhps">we are 
dealing</span> <span class="ecxhps">solely</span> <span class="ecxhps">the</span> <span class="ecxhps">boundary</span> <span class="ecxhps">relationship,</span> <span class="ecxhps">however, even</span> <span class="ecxhps">being</span> <span class="ecxhps">employed by</span> <span class="ecxhps">other relations</span> <span class="ecxhps">do not see</span> <span class="ecxhps">problems</span> <span class="ecxhps">because it</span> <span class="ecxhps">is defined by the</span> <span class="ecxhps">tag</span> <span class="ecxhps">name</span> <span class="ecxhps">and is 
in</span> <span class="ecxhps">its correct position</span><span>.</span><br><br><span class="ecxhps">Particularly</span> <span class="ecxhps">not identify</span> <span class="ecxhps">employment status</span> <span class="ecxhps">of that</span> <span class="ecxhps">node when</span> <span class="ecxhps">the tag</span> <span class="ecxhps">name</span> <span class="ecxhps">is missing</span> <span class="ecxhps">and</span> <span class="ecxhps">also</span> <span class="ecxhps">can not</span> 
<span class="ecxhps">identify</span> <span class="ecxhps">situation in which</span> <span class="ecxhps">an unnamed</span> <span class="ecxhps">relationship can</span> <span class="ecxhps">hire a</span> <span class="ecxhps">node also</span> <span class="ecxhps">unnamed</span><span>.</span> <span class="ecxhps">I say this because</span> 
<span class="ecxhps">we are referring to</span> <span class="ecxhps">node</span> <span class="ecxhps">similar to that</span> <span class="ecxhps">name in any</span> <span class="ecxhps ecxalt-edited">relations that the</span> <span class="ecxhps">employed.</span></span></div>
<div><span lang="en"><span class="ecxhps"></span></span>&nbsp;</div>
<div><span lang="en"><span class="ecxhps">Marcio</span></span> 
<div style="FONT-SIZE:small;TEXT-DECORATION:none;FONT-FAMILY:&quot;Calibri&quot;;FONT-WEIGHT:normal;COLOR:#000000;FONT-STYLE:normal;DISPLAY:inline;"></div>
<div style="FONT:10pt tahoma;">
<div><font face="Calibri"></font>&nbsp;</div>
<div style="BACKGROUND:#f5f5f5;">
<div style=""><b>From:</b> <a title="gpetermann_muenchen@hotmail.com" href="mailto:gpetermann_muenchen@hotmail.com">Gerd Petermann</a> </div>
<div><b>Sent:</b> Thursday, May 21, 2015 4:30 AM</div>
<div><b>To:</b> <a title="mkgmap-dev@lists.mkgmap.org.uk" href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a> 
</div>
<div><b>Subject:</b> [mkgmap-dev] [Patch v2] use role=label member to place 
POI</div></div></div>
<div>&nbsp;</div></div>
<div style="FONT-SIZE:small;TEXT-DECORATION:none;FONT-FAMILY:&quot;Calibri&quot;;FONT-WEIGHT:normal;COLOR:#000000;FONT-STYLE:normal;DISPLAY:inline;">
<div dir="ltr">Hi all,<br><br>sorry, v1 was missing a check for null , attached is 
v2, the binary is here:<br><code><a href="http://files.mkgmap.org.uk/download/269/mkgmap.jar" target="_blank">http://files.mkgmap.org.uk/download/269/mkgmap.jar</a><br><br></code>To 
ease testing I've added a log message with error level ,e.g. <br><br><font style="FONT-SIZE:12pt;" size="3">...&nbsp; <b>using label node as location</b> for 
POI for rel 334443 Goiás at -15.933471/-50.140561</font><font style="FONT-SIZE:12pt;" size="3"><br></font><br>it will also complain loudly when 
the node is not used because the names don't match:<br>... rel 
http://www.openstreetmap.org/relation/331515 ,<b>node with role label is ignored 
because it has a different name<br><br></b>Please suggest better text for the 
messages.<br>These messages show were the patch changes something, it will be 
<br>changed to debug/warn level before committing the patch.<br><br>If I got 
that right, Marcio and Anor propose to always use the label node<br>to place the 
generated POI for admin_level=10 boundaries,&nbsp; <br>but I see one potential 
problem here:<br>The node might also be used by different relations, and in that 
case<br>we will produce different POI at the same location.<br>I think this is 
something we want to avoid.<br><br>One more point I am not sure about:<br>The 
node in the mp-relation is only used when both the relation and the node have a 
name tag<br>(or whatever the name-tag-list tells mkgmap to use as name), <br>and 
when these are equal.<br>Do you see a case where we should use the node even if 
one of the name tags is 
missing?<br><br>Gerd<br></div></div></div></div>
<br>_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</div>                                               </div></body>
</html>