<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>Hi all,<br><br>sorry, v1 was missing a check for null , attached is v2, the binary is here:<br><code><a href="http://files.mkgmap.org.uk/download/269/mkgmap.jar" target="_blank">http://files.mkgmap.org.uk/download/269/mkgmap.jar</a><br><br></code>To ease testing I've added a log message with error level ,e.g. <br><br><font style="font-size: 12pt;" size="3">... <b>using label node as location</b> for POI for rel 334443 Goiás at -15.933471/-50.140561</font><font style="font-size: 12pt;" size="3"><br></font><br>it will also complain loudly when the node is not used because the names don't match:<br>... rel http://www.openstreetmap.org/relation/331515 ,<b>node with role label is ignored because it has a different name<br><br></b>Please suggest better text for the messages.<br>These messages show were the patch changes something, it will be <br>changed to debug/warn level before committing the patch.<br><br>If I got that right, Marcio and Anor propose to always use the label node<br>to place the generated POI for admin_level=10 boundaries, <br>but I see one potential problem here:<br>The node might also be used by different relations, and in that case<br>we will produce different POI at the same location.<br>I think this is something we want to avoid.<br><br>One more point I am not sure about:<br>The node in the mp-relation is only used when both the relation and the node have a name tag<br>(or whatever the name-tag-list tells mkgmap to use as name), <br>and when these are equal.<br>Do you see a case where we should use the node even if one of the name tags is missing?<br><br>Gerd<br> </div></body>
</html>