<div dir="ltr"><div><div><div>Hi Gerd,<br><br></div>Sorry about the late reply. Your response ended up in my spam box and I just found it now. I did in fact make the patch again the wrong branch. Sorry about that - clearly I need to contribute more of my tweaks. :)<br><br></div>Anyway, I see you've committed the patch already so thanks for that.<br><br></div>Ben<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 17, 2015 at 9:43 AM, Gerd Petermann <span dir="ltr"><<a href="mailto:gpetermann_muenchen@hotmail.com" target="_blank">gpetermann_muenchen@hotmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div dir="ltr">Hi Ben,<br><br>sorry for the delay, I was biking for a few days. <br>I had small problems with your patch because it seems not to be based on the svn <br>version, so please double check the changes.<br><br>Gerd<br><br><div><hr>Date: Tue, 8 Sep 2015 16:25:46 +0200<br>From: <a href="mailto:ben@bagu.org" target="_blank">ben@bagu.org</a><br>To: <a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>Subject: Re: [mkgmap-dev] [patch] add support for information=guidepost POI in default style<div><div class="h5"><br><br><div dir="ltr"><div><div>Hi Gerd,<br><br></div>I've attached a new patch with the previously mentioned change. I've also changed the other POI using 0x2f0c to 'amenity=toilets & highway=rest_area' which seems to match the POI type better.<br><br></div>Thanks, Ben<br></div><div><br><div>On Tue, Sep 8, 2015 at 3:49 PM, Ben Konrath <span dir="ltr"><<a href="mailto:ben@bagu.org" target="_blank">ben@bagu.org</a>></span> wrote:<br><blockquote style="border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>Hi Gerd,<br><br></div>I didn't spend too much time digging into this but I agree that it makes sense to solve this correctly.<br></div><div><div><div><div><div><div><br></div><div>According to this XLS file with Garmin POIs, 0x2f0c is for Toilets and will be listed in the the Auto Services -> Rest Area / Tourist Info category. <br></div><div><br><a href="http://www.cferrero.net/maps/downloads/garmin_feature_list.xls" target="_blank">http://www.cferrero.net/maps/downloads/garmin_feature_list.xls</a><br><br>> 0x2F0C Toilet Blue, small Auto Services Rest Area / Tourist Info Yes Restroom<br><br></div><div>According to the osm tag page, tourism=information is for information sources, not toilets.<br><br><a href="https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dinformation" target="_blank">https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dinformation</a><br><br></div><div>I propose that we just change tourism=information to 0x4c00 regardless of the the information=* refinement and ignore the previous patch.<br></div><div><br>tourism=information [0x4c00 resolution 24]<br><br>What do you think?<br><br></div><div>Thanks, Ben<br></div></div></div></div></div></div></div><div><div><div><br><div>On Tue, Sep 8, 2015 at 2:48 PM, GerdP <span dir="ltr"><<a href="mailto:gpetermann_muenchen@hotmail.com" target="_blank">gpetermann_muenchen@hotmail.com</a>></span> wrote:<br><blockquote style="border-left:1px #ccc solid;padding-left:1ex">Hi Ben,<br>
<br>
the node in your example has the tag tourism=information<br>
and the default style contains the rule.<br>
tourism=information [0x2f0c resolution 24]<br>
<br>
Your patch adds the rule<br>
information=guidepost [0x4c00 resolution 24]<br>
<br>
I'd prefer to modify the existing rule,<br>
but I don't know which of the types is more<br>
likely to show the wanted icon.<br>
<br>
Gerd<br>
<br>
<br>
<br>
Ben Konrath wrote<br>
<div><div>> Hi,<br>
><br>
> The default style currently has information=guidepost POIs set as a toilet<br>
> icon. This patch changes information=guidepost to be an 'i' in a circle.<br>
> For reference, here's an example of a POI with this tag:<br>
><br>
> <a href="https://www.openstreetmap.org/node/2883638464" rel="noreferrer" target="_blank">https://www.openstreetmap.org/node/2883638464</a><br>
><br>
> Thanks, Ben<br>
><br>
</div></div>> _______________________________________________<br>
> mkgmap-dev mailing list<br>
<br>
> mkgmap-dev@.org<br>
<br>
> <a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
><br>
> mkgmap-add-support-for-information-guidepost.patch (746 bytes)<br>
> <<a href="http://gis.19327.n5.nabble.com/attachment/5854217/0/mkgmap-add-support-for-information-guidepost.patch" rel="noreferrer" target="_blank">http://gis.19327.n5.nabble.com/attachment/5854217/0/mkgmap-add-support-for-information-guidepost.patch</a>><br>
<br>
<br>
<br>
<br>
<br>
--<br>
View this message in context: <a href="http://gis.19327.n5.nabble.com/patch-add-support-for-information-guidepost-POI-in-default-style-tp5854217p5854227.html" rel="noreferrer" target="_blank">http://gis.19327.n5.nabble.com/patch-add-support-for-information-guidepost-POI-in-default-style-tp5854217p5854227.html</a><br>
Sent from the Mkgmap Development mailing list archive at Nabble.com.<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
<br>_______________________________________________
mkgmap-dev mailing list
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a></div></div></div> </div></div>
<br>_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br></blockquote></div><br></div>