<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Hi Greg,</p>
<p><br>
</p>
<p>thanks for the report. I think I'll commit the patch on friday, let's see</p>
<p>what happens...</p>
<p><br>
</p>
<p>Gerd<br>
</p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>Von:</b> mkgmap-dev <mkgmap-dev-bounces@lists.mkgmap.org.uk> im Auftrag von greg crago <gregcrago@gmail.com><br>
<b>Gesendet:</b> Dienstag, 29. März 2016 04:10<br>
<b>An:</b> Development list for mkgmap<br>
<b>Betreff:</b> Re: [mkgmap-dev] [Patch v1] change process-destination option</font>
<div> </div>
</div>
<div>
<div dir="ltr">Patch <span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">patched r3673. works!</span>
<div><font face="Calibri, Arial, Helvetica, sans-serif" color="#000000"><span style="font-size:16px"><br>
</span></font></div>
<div><font face="Calibri, Arial, Helvetica, sans-serif" color="#000000"><span style="font-size:16px">no destination tag for no destination<br>
</span></font>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><br>
</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Thanks</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><br>
</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Look great</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><br>
</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Greg</span></div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Mar 28, 2016 at 8:49 AM, Gerd Petermann <span dir="ltr">
<<a href="mailto:GPetermann_muenchen@hotmail.com" target="_blank">GPetermann_muenchen@hotmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">
<div style="font-size:12pt; color:#000000; background-color:#ffffff; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi Greg,</p>
<p><br>
</p>
<p>Just to make sure: You have to use the special binary from the link</p>
<p>provided or you can use the patch to compile your own binary.</p>
<p><br>
</p>
<p>I've created the patch to solve your problem. So I am now</p>
<p>waiting for your results. When you say that it helps you and nobody</p>
<p>else claims that it causes too much trouble to change the style I'll <br>
</p>
<p>probably commit it. <br>
</p>
<p><br>
</p>
<p><br>
</p>
<p>Gerd<br>
</p>
<p><br>
</p>
<br>
<br>
<div style="color:rgb(0,0,0)">
<hr style="display:inline-block; width:98%">
<div dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><span class=""><b>Von:</b> mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk" target="_blank">mkgmap-dev-bounces@lists.mkgmap.org.uk</a>> im Auftrag von
greg crago <<a href="mailto:gregcrago@gmail.com" target="_blank">gregcrago@gmail.com</a>><br>
</span><b>Gesendet:</b> Montag, 28. März 2016 14:37
<div>
<div class="h5"><br>
<b>An:</b> Development list for mkgmap<br>
<b>Betreff:</b> Re: [mkgmap-dev] [Patch v1] change process-destination option</div>
</div>
</font>
<div> </div>
</div>
<div>
<div class="h5">
<div>
<div dir="ltr">i assumed this patch would have been in r3674. I will use r3673. Can you tell me when this will be incorporated in the main releases?
<div><br>
</div>
<div>Greg</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sun, Mar 27, 2016 at 2:37 PM, Gerd Petermann <span dir="ltr">
<<a href="mailto:GPetermann_muenchen@hotmail.com" target="_blank">GPetermann_muenchen@hotmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">
<div style="font-size:12pt; color:#000000; background-color:#ffffff; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi Greg,</p>
<p><br>
</p>
<p>you say that you use r3674, not the patched r3673.</p>
<p>Please use this binary:</p>
<p><a href="http://files.mkgmap.org.uk/download/295/mkgmap.jar" target="_blank">http://files.mkgmap.org.uk/download/295/mkgmap.jar</a></p>
<p><br>
</p>
<p>Gerd<br>
</p>
<br>
<br>
<div style="color:rgb(0,0,0)">
<hr style="display:inline-block; width:98%">
<div dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>Von:</b> mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk" target="_blank">mkgmap-dev-bounces@lists.mkgmap.org.uk</a>> im Auftrag von greg crago <<a href="mailto:gregcrago@gmail.com" target="_blank">gregcrago@gmail.com</a>><br>
<b>Gesendet:</b> Sonntag, 27. März 2016 20:50
<div>
<div><br>
<b>An:</b> Development list for mkgmap<br>
<b>Betreff:</b> Re: [mkgmap-dev] [Patch v1] change process-destination option</div>
</div>
</font>
<div> </div>
</div>
<div>
<div>
<div>
<div dir="ltr">I am not getting an empty string for a destination tag that does not exist.
<div><br>
</div>
<div>I am using mkgmap r3674 and using the DEFAULT style with one line added at the top of the line file:</div>
<div><br>
</div>
<div>highway=* { echo 'BEFORE destination=${destination}'}<br>
</div>
<div><br>
</div>
<div>Upon execution, the command prompt window shows:</div>
<div>BEFORE destination=Beck Road</div>
<div><br>
</div>
<div>I expected the string would be empty, since no destiantion tag exists.</div>
<div><br>
</div>
<div>Attached is the osm.pbf file</div>
<div><br>
</div>
<div>The patch was suppose to:</div>
<div><br>
</div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">1) the tag destination is not changed by mkgmap</span><br>
</div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><br>
</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Am I missing something?</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px"><br>
</span></div>
<div><span style="color:rgb(0,0,0); font-family:Calibri,Arial,Helvetica,sans-serif; font-size:16px">Greg</span></div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Mar 23, 2016 at 7:37 PM, Alexandre Loss <span dir="ltr">
<<a href="mailto:alexandre.loss@gmail.com" target="_blank">alexandre.loss@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div>Hi Gerd,<br>
<br>
</div>
Nothing regarding the limits of 10m.<br>
</div>
I'm only saying that I keep mkgmap:exit_hint=true in my "lines" and it continues perform as expected.<br>
<br>
[],<br>
<br>
</div>
Alexandre<br>
</div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-03-23 14:51 GMT-03:00 Gerd Petermann <span dir="ltr">
<<a href="mailto:GPetermann_muenchen@hotmail.com" target="_blank">GPetermann_muenchen@hotmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">
<div style="font-size:12pt; color:#000000; background-color:#ffffff; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi Alexandre,</p>
<p><br>
</p>
<p>Thanks for testing.<br>
</p>
<p>I see no problem with the code for process_exits, I think it only adds <br>
</p>
<p>tags with the mkgmap prefix. Do you mean the limits regarding 10m ? <br>
</p>
<p><br>
</p>
<p>Gerd<br>
</p>
<br>
<div style="color:rgb(0,0,0)">
<hr style="display:inline-block; width:98%">
<div dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>Von:</b> mkgmap-dev <<a href="mailto:mkgmap-dev-bounces@lists.mkgmap.org.uk" target="_blank">mkgmap-dev-bounces@lists.mkgmap.org.uk</a>> im Auftrag von Alexandre Loss
<<a href="mailto:alexandre.loss@gmail.com" target="_blank">alexandre.loss@gmail.com</a>><br>
<b>Gesendet:</b> Mittwoch, 23. März 2016 17:32<br>
<b>An:</b> Development list for mkgmap<br>
<b>Betreff:</b> Re: [mkgmap-dev] [Patch v1] change process-destination option</font>
<div> </div>
</div>
<div>
<div>
<div>
<div dir="ltr">
<div>
<div>Hi Gerd,<br>
<br>
</div>
After update my local mkgmap with this patch, follow my tests' results (in a small fictitious map):<br>
<br>
</div>
1) Without change my proprietary style "lines" file, I get the following error as expected:<br>
<div>
<div>
<div>
<div><br>
<span style="font-family:monospace,monospace">GRAVE (StyledConverter): 03137600-lagoa_santa.osm: At least one 'lines' rule in the style contains the expression mkgmap:dest_hint=true, it should be changed to mkgmap:dest_hint=*</span><br>
<br>
</div>
<div>2) Changing mkgmap:dest_hint=true to *, as directed above, the map was compiled without error and the result works as expected.<br>
<br>
</div>
<div>Therefore, I think that the patch is working like charm.<br>
<br>
</div>
<div>I didn't change any exit_hint in lines file and the exits continue working as expected. Are you changing only dest_hint or are you gonna change dest_exit also?<br>
<br>
</div>
<div>Regards,<br>
<br>
</div>
<div>Alexandre <br>
</div>
</div>
</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2016-03-23 6:07 GMT-03:00 Gerd Petermann <span dir="ltr">
<<a href="mailto:GPetermann_muenchen@hotmail.com" target="_blank">GPetermann_muenchen@hotmail.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">
<div style="font-size:12pt; color:#000000; background-color:#ffffff; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Hi all,</p>
<p><br>
</p>
<p>please read carefully:</p>
<p><br>
</p>
<p>Up to now the process_destination option is a bit problematic because <br>
</p>
<p>it may add the tag destination=* to an existing OSM element, and I think this</p>
<p>is not good, all tags added by mkgmap should have the mkgmap: prefix.<br>
</p>
<p><br>
</p>
<p>As Greg pointed out this causes problems for style authors who want to</p>
<p>create special hints depending on tags like destination:street .<br>
</p>
<p><br>
</p>
<p>The attached patch changes the method like this:</p>
<p>1) the tag destination is not changed by mkgmap</p>
<p>2) Instead the special tag mkgmap:dest_hint is now set to the <br>
</p>
<p>destination string that was found in one of the tags listed in this code snippet:<br>
</p>
<p> tags.add("destination");<br>
tags.add("destination:lanes");<br>
tags.add("destination:lanes:forward");<br>
tags.add("destination:lanes:backward");<br>
tags.add("destination:forward");<br>
tags.add("destination:backward");<br>
tags.add("destination:street"); <br>
</p>
<p><br>
</p>
<p>(BTW: This is also the order of evaluation in mkgmap searches since r3673, of cause
<br>
</p>
<p>forward/backward are checked depending on the direction of the way)<br>
</p>
<p><br>
</p>
<p>For style authors this means that they have to <br>
</p>
<p>1) change all rules with mkgmap:dest_hint=true to mkgmap:dest_hint=*</p>
<p>2) change the rule that produces the hint to something like this:<br>
mkgmap:dest_hint=*<br>
{ set dest_hint = '${destination:ref|subst: =>} ${mkgmap:dest_hint|subst:;=> |subst:/=> }' |<br>
'${ref|subst: =>} ${mkgmap:dest_hint|subst:;=> |subst:/=> }' | <br>
'${mkgmap:dest_hint|subst:;=> |subst:/=> }';<br>
} <br>
</p>
<p>Basically all places where "destination" was used were changed to mkgmap:dest_hint.</p>
<p><br>
</p>
<p>I am aware that this could cause trouble, so I've added a check that complains when</p>
<p>the style contains an expression mkgmap:dest_hint=true . <br>
</p>
<p><br>
</p>
<p>A binary can be found here:</p>
<p><a href="http://files.mkgmap.org.uk/download/295/mkgmap.jar" target="_blank">http://files.mkgmap.org.uk/download/295/mkgmap.jar</a></p>
<p><br>
</p>
<p>With the default style this produces the same img file as r3673. <br>
</p>
<p>Please let me know if you see problems with your style.<span><font color="#888888"><br>
</font></span></p>
<span><font color="#888888">
<p><br>
</p>
<p>Gerd<br>
</p>
</font></span></div>
</div>
<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk" target="_blank">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
_______________________________________________<br>
mkgmap-dev mailing list<br>
<a href="mailto:mkgmap-dev@lists.mkgmap.org.uk">mkgmap-dev@lists.mkgmap.org.uk</a><br>
<a href="http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev" rel="noreferrer" target="_blank">http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>