[mkgmap-dev] [PATCH] Bernhard's POI address autofilling code

Mon Feb 16 08:35:51 GMT 2009

On Sun, Feb 15, 2009 at 02:30:44PM +0000, Mark Burton wrote:
> 
> Hi,
> 
> The attached nod branch patch is Bernhard's code for autofilling POI
> address info. I have made a few trivial changes. It adds these options:
> 
> --pois-addresses 
> 	Add address / phone information to POIs. Address info is read
> 	according to the "Karlsruhe" tagging schema. If no address
> 	info is given name of next city is used. Automatic filling
> 	could be extended using the "location-autofill" option.
> 
> --location-autofill=''number''
> 	Controls how country region information is gathered for
> 	cities, streets and pois
> 
> 	0       (Default) Info of nearest city is taken. If no country
> 		region info is present for next city the default
> 		passed default country region is used. The country
> 		region info is gathered by analysis of the cities
> 		is_in tags.
> 
> 	1 	Additional analysis of partial is_in info to get relations
> 		between hamlets and cities
> 
> 	2 	Brute force search for nearest city with info if all methods
> 		before failed. Warning cities my end up in the wrong
> 		country/region.
> 
> 	3	Enables debug output about suspicious relations that might
> 		cause wrong country region info
> 
> I have tested it a little and didn't obviously break anything so I
> think it can be committed soon. As it affects quite a few files, I
> just thought I would send it out in patch format first. If you have the
> time, please try it out. If no negative feedback comes back in the next
> 24 hours or so, I will commit it to the nod branch.

I'd prefere not to mix up the patches.  The current nod branch can be
merged to trunk now and then the poi branch then updated from the trunk.
The poi branch should already contain v5 of the patch, perhaps there are a few
more changes I'm not aware of that need applying.

Then I'd like to split the POI patch into the parts that work entirely
on information from the node and the part that implements the
pois-addresses and location-autofill functionallity.
I'm fine with the first part to be merged to trunk as soon as possible.

For the autofill etc. there are other ways that this could be done, for
example you could supply a separate polygon file that contains all the
regions, countries or cities.  The Karlsruhe scheme may not be used
everywhere. The current method of working entirely with the .osm file
is fine, but I'd like to think about making it
easy to switch between strategies, using some kind of plugin or filter
system.  What do you think?

..Steve