[mkgmap-dev] [PATCH v4] - alpha patch to support road find by name

Sun Mar 15 22:25:56 GMT 2009

Hi marko,

> The intersection search works for me (Edge 705), even without selecting
> a city name.  (Vantaa would be quite at the bottom of the list of all
> Finnish cities, towns, suburbs and villages.)  The street name search
> apparently wants to know the street number before starting the search.
> Entering "1" works (and shows the wrong end for a nearby street that
> doesn't have street numbers in the OSM database).
> 
> The search for "1 Sorvapolku" (again, without selecting a city) returns
> three matches, all for the same highway=cycleway that happens to have a
> name.  The way consists of three sections because of a motorway underpass
> (tunnel).  It might be a good idea to merge such ways if possible, when
> forming the street name database.  Similarly, "1 Ahjokatu" returns 6
> matches, all in Lohikoski, FIN.

Yes, it doesn't try to join road segments with the same name at the
moment. I'm not even thinking about that until the basic stuff is
working correctly.

> "1 Otakaari" finds 7 matches, 6 in "Otaniemi, FIN" and 1 in
> "Teekkarikylä, FIN".  (Teekkarikylä is what the student village is
> called at the Helsinki University of Technology.  The whole campus
> area is called Otaniemi.)  However, if I select the city "Espoo, FIN"
> (which Otaniemi and Teekkarikylä are in), no matches will be found.
> Furthermore, even if I select a city, the selection of city names will
> apparently offer me all street names of Finland, not those in the city.

Yes, selecting a city does not work at all.
> 
> > As for the number field, I haven't thought yet how that would get its
> > data.
> 
> Have you figured out where and how to store the street number information
> in the image file?

I have some info on that but haven't looked into it yet.

> 
> > +	public int compareTo(Object other) {
> > +		City o = (City)other;
> > +		if(o == this)
> > +			return 0;
> > +		if(label != null && o.label != null)
> > +			return label.compareTo(o.label);
> // I'd do this:
> 		// define the null label as the smaller one
> 		if (label != null) return 1;
> 		if (o.label != null) return -1;
> 		// both labels are null: compare hashCode()
> 		return label.hashCode() - o.label.hashCode();
> // instead of this:
> > +
> > +		return 1;	// not ordered, just different
> > +	}
> >  }

Yes, I'll try that.

> Would the above suggestion fix the sorting of the city list?

I suspect not.

> The patch doesn't seem to break anything for me.  I can still generate
> finland.osm.bz2, and routing still works.

Good.

Cheers,

Mark