[mkgmap-dev] [PATCH] splitter with Java 5, was: exception in --list-styles

Tue Apr 21 08:21:12 BST 2009

Hi Marko,

you are right. I did the replacement too "locally". But the patch was  
more to try whether it works at all, because I don't know whether it  
wants Java 6 just due to those lines or whether there is another (less  
obvious) reason.

Am 21.04.2009 um 07:37 schrieb Marko Mäkelä:

> On Tue, Apr 21, 2009 at 01:02:39AM +0200, Thilo Hannemann wrote:
>> 			while ((line = br.readLine()) != null) {
>> 				line = line.trim();
>> -				if (line.isEmpty() || line.charAt(0) == '#')
>> +				if ((line != null && line.length() == 0) || line.charAt(0) ==  
>> '#')
>> 					continue;
>>
>> 				Matcher matcher = pattern.matcher(line);
>
> Why the line != null?  I wouldn't expect line.trim() to return null
> or pattern.matcher() to accept null.
>
> Also, would one public static Locale rootlocale in some class suffice?
> Your patch is initializing rootlocale as a local variable, in two  
> places.
>
> 	Marko
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev