[mkgmap-dev] [PATCH v1] - Route centre tweaks

Wed Sep 23 12:34:57 BST 2009

Hi Marko,

Thanks for the report.

> I generated the same map with the only difference being this patch.  The
> file was a little smaller:
> 
> -rw-r--r-- 1 marko marko 36888576 22.9. 09:01 gmapsuppa.img
> -rw-r--r-- 1 marko marko 36510720 23.9. 14:06 gmapsupp.img

> > So please test this patch (it replaces the previous patch) and let me
> > know if their are any issues.
> 
> Routing seems to be unaffected.  I tested the same route, both bicycle
> (253 km) and car (204 km).

Good.

> > You must enable assertions, otherwise if the data structures overflow
> > you won't know until mapsource/gps barfs.
> 
> There are a few differences between the generated gmapsupp.img if I enable
> assertions.  The files are of the same size, though.  Come to think of it,
> the differences could be attributed to --max-jobs.  But the diff of hexdump
> is only 64 lines, or 16 differing 16-byte blocks.

I think the differences will just be the time stamps. Enabling
assertions really should not make the output change otherwise.

That's a least 3 positive reports so I think this patch is probably OK
to commit.

Cheers,

Mark