[mkgmap-dev] More Dog patches

Tue Nov 17 10:15:55 GMT 2009

Hi Marko,

>I had a look at your patch.  

Thanks for taking the time

>I think that the character encoding should
>be ASCII or UTF-8.  The apparent encoding of your patch is Microsoft
>Code Page 1252.>

Ahh, that won't do- I want to help improve mkgmap, not hamper it!
I'll try to find out what that means and will refrain from patching till
then.
.. .. 
I had a look at GNU DiffUtils to see if I'm going wrong somewhere there.
No options for encoding (at least NAFAICT)

What do happen is: I hand edit the header paths, with wordpad, to
correspond to the svn paths. I suppose when I save it, it saves in 1252
i.s.o utf-8. I can do the editing in Word and encode to UTF-8 if it is a
problem. How can you tell which character encoding is used? 

What is the reason for the headings
 ---
 +++ and 
 index:
are they needed for the patch to be applied, or do I just waste my time
to hand edit it?

>> BTW I see a heading like  
>> 
>> Index: doc/README.java  
>> 
>> on the patches of others. Is it hand edited in, or do you use
different
> DiffUtils than I do?
>
>"svn diff" will output that header.

Ok, does that mean you diff the paths on-line to create your patches?
Is it OK then if I don't include that header or does it make it more
difficult to apply the patch if I don't?
Hang on - I've tried to get a diff from comparing two paths on svn, but
it didn't work: all I get is a diff like output on screen (which is fine
to read, but does not save / download as a diff file with the + - @ etc
- how do you get a diff file from it? I've tried to copy & paste but all
the diff symbols has to be added manualy then - I'm guaranteed to make a
typo.
.. ..
Sorry, I tried svn quickly to see if I can figure it out: no luck.
Maybe someone will be so kind to spell it out for me.

BennieD
#####################################################################################
Scanned by MailMarshal - Marshal's comprehensive email content security solution. 
Download a free evaluation of MailMarshal at www.marshal.com
#####################################################################################