[mkgmap-dev] Don't let action rule execute its actions if its type isn't going to be used

Sun Nov 29 22:50:03 GMT 2009

Hi Felix,

Thanks for the report.

> Overall: Great it's the first time the patch actually seems to work as
> expected (as expected when looking at the result with gpsmapedit).
> Inside Mapsource it works 100% when not starting or ending on the street
> that is oneway. So if you have to route over such a stretch - it will work
> as expected - with different speeds depending on the dircection of travel.
> This is the greatest feature we have since routing was
> introduced!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> 
> Only if you start or end the route against the oneway of the way on the top,
> it might end up to route to one end of the street, and then run the opposite
> direction back. This is no major concern to me at all and probably simply
> caused by the fact that if you click somewhere it always chooses the top
> road, and there are no interchanging nodes so it has to route to the end of
> the street to change to the street that lies below.
> 
> -- I did not notice any drawbacks using this patch, and it makes the
> "continue" command much more useful. Now we really have a unique feature.
> (and I have a lot of work thinking about all the great stuff I can use this
> for to improve routing)

Good, hopefully, that will keep you quiet for a while!

>  I think you can safely commit this!

OK, I'll do that soon.

> (for anyone wanting to use this like me for different speed depending of
> direction, now having the slower way with oneway=no also works great, I'll
> play around a bit to see whether two opposing oneways, or one fast oneway
> and slow way "without direction" works better).

Cheers,

Mark