[mkgmap-dev] [PATCH] set mkgmap:dead-end-check=false when endpoints have FIXME=*

Wed Dec 2 20:52:51 GMT 2009

Hi Mark,

> > I came across an incompletely mapped area that has some dead-end oneways,
> > and mkgmap duly complained.  Initially, I "fixed" this with a bogus road
> > that had a FIXME tag, but the original mapper reverted that change.
> > Now I have added fixme=continue to each bogus oneway.  I wanted to suppress
> > the dead-end check if the endpoints of the oneway have FIXME or fixme set,
> > but neither Coord nor CoordNode carry any OSM attributes.  Where could
> > this be achieved?  I would rather not add any mkgmap:dead-end-check=no
> > to the OpenStreetMap repository?  The FIXME would be more universal and
> > also show up in validators.
> 
> Yes, something like that could be done. Not sure about doing it for
> FIXME=*, though because if it said FIXME='not sure about road name'
> or something else that was unrelated to the routing/connectivity of
> the way then disabling the dead end check would not be appropriate.

I put my foot where my mouth is and implemented this in the OSM parser:
if either endpoint of a oneway carries a FIXME or fixme attribute,
mkgmap:dead-end-check=false will be added to the way.  It is left as an
exercise for the reader to port the patch to the MP parser. :-)

I tested the patch with --report-dead-ends 1 and 2 and got zero or
several oneway warnings, depending on whether FIXME was set on the
way endpoints.

Best regards,

	Marko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fixme-dead-end-check.patch
Type: text/x-diff
Size: 3155 bytes
Desc: not available
Url : http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20091202/670895ad/attachment.bin 