[mkgmap-dev] mkgmap dropping ways on multipolygon boundary "outer"

Wed Dec 30 14:57:30 GMT 2009

On 28.12.2009 09:42, Mark Burton wrote:
> Hi Felix,
>
>    
>> Yip, that patch works great. (using only this patch, without the earlier
>> patch; if I add earlier patch too I loose the relations again)
>>      
> Yes, it replaces the earlier patch.
>
> Good.
>
> I am tempted to commit this - does anyone think that preserving the
> original ways is a bad idea? If so, please speak up.
>
> Cheers,
>
> Mark
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>    
Is there a reason for not committing the patch? It is working great for 
me and also Steve found it good

But yes, maybe they should be duplicated as well, I'm not against
duplicating the ways (and I like Mark's second patch), just against)
doing it twice without a rationale.


I am using it since a few days without probs. I have not noticed any 
missing coastlines using this patch (though I did not have a look at 
places with many coastlines due to islands).
Felix
--

diff --git a/src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java b/src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java
index e2f3c64..0ff5659 100644
--- a/src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java
+++ b/src/uk/me/parabola/mkgmap/reader/osm/MultiPolygonRelation.java
@@ -35,7 +35,7 @@ public class MultiPolygonRelation extends Relation {
                 String value = pairs.getValue();

                         if (value != null&&  pairs.getKey() instanceof Way) {
-                               Way way = (Way) pairs.getKey();
+                               Way way = ((Way)pairs.getKey()).duplicate();
                                 if (value.equals("outer")){
                                         outers.add(way);
                                 } else if (value.equals("inner")){



