[mkgmap-dev] [PATCH v1] Merge from the mp branch

Sat Jan 16 21:31:28 GMT 2010

Hi WanMil,

> The attached patch contains a merge from the mp branch and fixes lots of 
> multipolygon issues.
> I have also added some more javadoc and code comments, renamed methods 
> and variables and removed not very useful logging statements.
> 
> The mp branch is no longer needed.

I tried making the Baltic map using this version of the MP code and
--generate-sea=multipolygon,no-sea-sectors

I received a lot of messages like this:

2010/01/16 21:06:59 WARNING (MultiPolygonRelation): Unclosed polygons in multipolygon relation 27016:
2010/01/16 21:06:59 WARNING (MultiPolygonRelation):  - way: 29411823 role: outer osm: http://www.openstreetmap.org/browse/way/29411823
2010/01/16 21:06:59 WARNING (MultiPolygonRelation):  - way: 30108097 role: outer osm: http://www.openstreetmap.org/browse/way/30108097
2010/01/16 21:06:59 WARNING (MultiPolygonRelation):  - way: 29413658 role: outer osm: http://www.openstreetmap.org/browse/way/29413658

and:

2010/01/16 21:07:00 SEVERE (MultiPolygonRelation): Multipolygon http://www.openstreetmap.org/browse/relation/51154 contains intersected ways
2010/01/16 21:07:00 SEVERE (MultiPolygonRelation): - http://www.openstreetmap.org/browse/way/4611686018427387987

I guess that last way (with the fake id) is some joined up coastline
segments. (incidentally, there's no point in creating an OSM URL for
elements with fake ids, perhaps we should spot the fake ids and output
something more appropriate).

Anyway, the resulting map has a few nice islands but all of the land
mass that touches the edges of a tile is flooded.

I tried a couple of the tiles with the old MP code and the flooding
went away so I think it's the new code rather than the generate-sea
code that's causing the flooding.

Mark