[mkgmap-dev] Generating sea

Fri Feb 18 17:11:23 GMT 2011

Hi Wanmil,

I tried a value of 12000 for close-gaps in mkgmap. The missing sea is
gone (mkgmap-r1846). But I found in the northeast another missing sea
(http://www.openstreetmap.org/?lat=53.7177124&lon=14.2640711&zoom=13).
With additional max-nodes=1000000 in splitter this is also o.k.

May be that's fortune too and can change in future.

Thanks for your work.
Josef

Am 18.02.2011 17:02, schrieb WanMil:
> Josef,
> 
> I succeeded to track it down.
> The change was introduced in r1730. But it was pure fortune that a 
> result which pleased you was created before r1730.
> The sea generation algorithm tries to connect open coastlines when they 
> are closer than the specified gap size. But this depends on the order of 
> the coastlines in an internal list. The order was and is not defined in 
> any way but for this special tile it changed with r1730.
> 
> As a result: it's not a new bug. I will put it on my list if I can 
> modify the algorithm to create distinct results.
> 
> Have fun!
> WanMil
> 
>> Hi Wanmil,
>>
>> where can I get the executable builds (URL)?
>>
>> Greetings
>> Josef
>>
>>
>> Am 17.02.2011 18:24, schrieb WanMil:
>>> Hi Josef,
>>>
>>> I can reproduce the sea problem. It has something to do with the
>>> extend-sea-sectors algorithm. I don't know when I have time to find the bug.
>>>
>>> If you like you might help me to test the following mkgmap revisions:
>>> <1682, 1684, 1704, 1712. Most important is 1712. 1682 and 1684 are from
>>> the binfmt branch.
>>>
>>> You only need to compile the tile with the problem (it's 30000007 in my
>>> splitted tiles).
>>>
>>> Have fun!
>>> WanMil
>>>
>>>> Hi Wanmil,
>>>>
>>>> No findings?
>>>>
>>>> The screenshots show clearly the difference between the maps created
>>>> with mkgpmap-r1625 (generating sea is good, except the ghost rivers) and
>>>> newer mkgmap-versions (incl. -r1846).
>>>>
>>>> Greetings
>>>> Josef
>>>>
>>>>
>>>>
>>>> Am 10.02.2011 19:17, schrieb Josef Latt:
>>>>> Hi Wanmil,
>>>>>
>>>>> Did you download the screenshots?
>>>>> The missing north sea in sea_good.jpg is IMHO normal. It's outside the
>>>>> bounding polygon.
>>>>>
>>>>> Thanks for your answer.
>>>>> Josef
>>>>>
>>>>>
>>>>> Parameters for splitter and mkgmap:
>>>>>
>>>>> java -ea -Xmx2560M -jar ./splitter/splitter.jar
>>>>> --mapid=30000001 --max-nodes=800000 germany.osm
>>>>>
>>>>> java -ea -Xmx2560M -jar ./mkgmap-r1829/mkgmap.jar \
>>>>> --description=OSM_DE \
>>>>> --country-name=Deutschland --country-abbr=DE \
>>>>> --name-tag-list="name:de,name,int_name" \
>>>>> --style-file=./style/ \
>>>>> --generate-sea=extend-sea-sectors,close-gaps=5000 \
>>>>> --family-id=3333 --product-id=1 \
>>>>> --series-name=OSM_Deutschland \
>>>>> --area-name=Deutschland \
>>>>> --overview-mapname=OSM_Deutschland \
>>>>> --tdbfile \
>>>>> --draw-priority=25 \
>>>>> --latin1 \
>>>>> --ignore-maxspeeds \
>>>>> --ignore-turn-restrictions \
>>>>> --no-poi-address \
>>>>> --max-jobs=2 \
>>>>> -c template.args 3333.TYP
>>>>>
>>>>>
>>>>>
>>>>> Am 10.02.2011 18:45, schrieb WanMil:
>>>>>> Josef,
>>>>>>
>>>>>> I downloaded the latest German extract from cloudmade.com. I splitted
>>>>>> the extract using the default settings. In the map most of the North Sea
>>>>>> is not created. Although this is not good I cannot reproduce your exact
>>>>>> problem.
>>>>>>
>>>>>> Please provide the following information:
>>>>>> * Splitter parameters
>>>>>> * Your exact mkgmap parameters
>>>>>>
>>>>>> WanMil
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I use the German extract from cloudmade.com. With mkgmap-r1815, 1827,
>>>>>>> 1829 generating sea (--generate-sea=extend-sea-sectors,close-gaps=5000)
>>>>>>> is incomplete. See screenshot sea_bad.jpg.
>>>>>>>
>>>>>>> Using mkgmap-r1625 generating sea is o.k. but there are some ghost
>>>>>>> rivers. See screenshots sea_good.jpg and Ghostriver.jpg.
>>>>>>>
>>>>>>> Vou can download the screenshots as ZIP here:
>>>>>>> http://ge.tt/#70BMn5z
>>>>>>>
>>>>>>> Greetings
>>>>>>> Josef
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> mkgmap-dev mailing list
>>>>>> mkgmap-dev at lists.mkgmap.org.uk
>>>>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>>>>
>>>>>
>>>>
>>>
>>> _______________________________________________
>>> mkgmap-dev mailing list
>>> mkgmap-dev at lists.mkgmap.org.uk
>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>>
>>
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 

-- 
PGP Schlüssel: 311D1055
http://keyserver.pgp.com