[mkgmap-dev] bug in mapsource installer

Fri Feb 18 22:19:32 GMT 2011

Thanks Nakor,

Right now mkgmap copy and pastes --series-name into those fields,
whereas family-name seems more logical. The drop-down name in mapsource is the series-name.

A few more things that could be added to the nsi. file:

A check if Mapsource and/or Basecamp is running. If this is the case, the installer must warn the user to close it before it continues. I copied it from the openmtb mapinstaller, you need a FindProcDLL plug-in to run this though:

Function .onInit
	FindProcDLL::FindProc "MapSource.exe"
	IntCmp $R0 1 0 notRunningMapSource
    MessageBox MB_OK|MB_ICONEXCLAMATION "Mapsource is running. Please close it first" /SD IDOK
    Abort
	notRunningMapSource:

	FindProcDLL::FindProc "BaseCamp.exe"
	IntCmp $R0 1 0 notRunningBaseCamp
    MessageBox MB_OK|MB_ICONEXCLAMATION "BaseCamp is running. Please close it first" /SD IDOK
    Abort
	notRunningBaseCamp:

FunctionEnd

And this one I find  also very convenient, run the uninstall.exe from the previous version
before installing the new version:

Section "MainSection" SectionMain
  SetOutPath "$INSTDIR"
  ExecWait '"$INSTDIR\Uninstall.exe" /S _?=$INSTDIR'
  File "${MAPNAME}.img"
  File "${MAPNAME}_mdr.img"
  File "${MAPNAME}.mdx"
  etc