[mkgmap-dev] [PATCH v2] Fix so that all polygons are really closed

Sun Feb 27 09:32:59 GMT 2011

On Sun, Feb 27, 2011 at 11:06:22AM +0200, Marko Mäkelä wrote:
>I am now testing the patch on Finland.

I got 2386 additional warnings. Some are for thin man_made=pier that 
have been drawn as lines. There is man_made=* in the polygons style 
file. Could we suppress the warnings for certain minor unclosed 
polygons? E.g., something like this:

building=* | man_made=* | amenity=* | tourism=*
{ add mkgmap:polygon-check=false } [0x13 resolution 24]

If I disable this rule altogether, the warning count drops from 2386 to 
476. That is, the selective suppression of the warnings would help a 
lot.

I would demote the 270 messages about automatic closure to the INFO 
level. That would leave 206 messages that need to be checked.

One more idea: you might add some extra treatment for polygons that are 
more than 1 "lap". For example, 
http://www.openstreetmap.org/browse/way/76559964 comprised of nodes 
902322231, 902322232, ..., 902322231, 902322232. The second 902322232 
triggered the error.

	Marko