[mkgmap-dev] Splitter PBF support patch

Wed May 25 20:19:54 BST 2011

On Wed, May 25, 2011 at 01:36:07PM -0400, Francisco Moraes wrote:
>On 2:59 PM, Marko Mäkelä wrote:
>>> Apart from these warnings, I am still getting the warnings about
>>> unclosed polygons, like this:
>>>
>>> 2011/05/19 23:54:39 WARNING (StyledConverter): 63240008.osm.pbf:
>>> Unclosed way http://www.openstreetmap.org/browse/way/23679990
>>> [natural=water] should be converted as shape but the start or end
>>> point lies inside the bbox. Skip it.
>>>
>>> For some reason, the pbf splitter workflow failed to issue the data
>>> error (one dead-end oneway) that I got reported for the same
>>> finland.osm.pbf when splitting it to osm.gz.
>>
>> These two issues are still unexplained and need to be fixed in my 
>> opinion.
>So, are you saying that the splitter itself should have done something 
>different on that tile with that way? I briefly compared both the XML 
>and PBF->XML output and they seemed to both have the same node refs.

Yes, I suspect that the PBF splitter output or the mkgmap PBF parser is 
broken or different from the XML output or parser in this aspect. I fed 
the same finland.osm.pbf file to the toolchain. The only difference was 
the output format of splitter (osm.pbf instead of osm.gz).

As far as I understand, it is a little challenging to compare the XML 
and PBF with each other, because splitter outputs 0.5 XML, which is no 
longer supported by Osmosis.

I may look at the code in some days if needed.  Sorry, I get an 
overdosis of software development at work, and I try to avoid doing too 
much of it in my spare time.

Best regards,

	Marko