[mkgmap-dev] mkgmap and bicycle routing

Sun Nov 6 23:52:17 GMT 2011

Am Sonntag 06 November 2011, 20:26:56 schrieb Marko Mäkelä:
> On Sun, Nov 06, 2011 at 11:52:47AM +0100, Thorsten Kukuk wrote:
> >It cannot be the GPS firmware, but I think it is a mkgmap bug:
> >>From ./src/uk/me/parabola/mkgmap/osmstyle/StyledConverter.java:
> >        protected boolean accessExplicitlyAllowed(String val) {
> >        
> >                if (val == null)
> >                
> >                        return false;
> >                
> >                return (val.equalsIgnoreCase("yes") ||
> >                
> >                        val.equalsIgnoreCase("designated") ||
> >                        val.equalsIgnoreCase("permissive"));
> >        
> >        }
> >
> >mkgmap does not know about "official", but as far as I understand
> >http://wiki.openstreetmap.org/wiki/Tag:access%3Dofficial we should
> >handle it in the same way as "yes".
> 
> Thank you for the analysis!
> 
> >I will try now a patched mkgmap. But as workaround setting
> >bicycle=official to bicycle=yes in the style file should fix the
> >routing problems, too.
> 
> I can commit the fix (adding "official" to the above tags), once you
> have verified it.
> 
> 	Marko

Sorry, but i oppose  commiting this 'fix' which IMO is a bug.
Do not add more semantic intepretation to the hardcoded part
of mkmap.  Instead write a stylefile rule that reflects to only one
value in the code above. This is not a workaround, this is the
better and cleaner way.

Best regards
Hasemann