[mkgmap-dev] [PATCH v2] Performance improvement by removing unused elements before the style processing

Thu Jan 5 20:38:17 GMT 2012

Hi Gerd,

I should read my own comments... :-)

But that seems to be a possible reason.
The POIGeneratorHook checks polygons for nodes tagged with 
building=entrance. If one node is found it is used by the 
POIGeneratorHook to set the POI for the polygon.

The building=entrance node might be removed by the patch and therefore 
the POIGeneratorHook places the node in the middle of the polygon.

But that's easy to check. I just have to move the point where new hook runs.

WanMil

> Hi WanMil,
>
> the comment says that something was not found, so the center of an area is
> taken. I assume this happens only in the patched version because that
> deletes this "something".
>
> Gerd
>
>
> WanMil wrote
>>
>> Hi Gerd,
>>
>> yes but why is it generated in the patched version and not in the
>> unpatched? The patch only removes elements but does not add any...
>>
>> WanMil
>>
>>> Hi WanMil,
>>>
>>> I guess this is generated in this part of POIGeneratorHook.java:
>>> 		if (poiCoord == null) {
>>> 			// did not find any label coord
>>> 			// use the common center point of the area
>>> 			poiCoord = polygon.getCofG();
>>> 		}
>>> 		
>>> 		Node poi = createPOI(polygon, poiCoord, AREA2POI_TAG);
>>>
>>> Ciao,
>>> Gerd
>>>
>>> --
>>> View this message in context:
>>> http://gis.638310.n2.nabble.com/PATCH-v1-Performance-improvement-by-removing-unused-elements-before-the-style-processing-tp7144978p7155869.html
>>> Sent from the Mkgmap Development mailing list archive at Nabble.com.
>>> _______________________________________________
>>> mkgmap-dev mailing list
>>> mkgmap-dev at .org
>>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-dev at .org
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>
>
> --
> View this message in context: http://gis.638310.n2.nabble.com/PATCH-v1-Performance-improvement-by-removing-unused-elements-before-the-style-processing-tp7144978p7155950.html
> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev