[mkgmap-dev] [Patch v2] LocationHook with new Quadtree

Thu Jan 12 21:01:07 GMT 2012

... and GetUsedTags() confused me for quite a while ;-)

I think it is a good idea to remove unused code.  Also in splitter, many classes are only referenced in the tests.  
Would it be an option to rename them to *.java.obsolete ?

Gerd

> Date: Thu, 12 Jan 2012 21:26:00 +0100
> From: wmgcnfg at web.de
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] [Patch v2] LocationHook with new Quadtree
> 
> uups, the changes for the Boundary class are missing.
> 
> So long I wondered why you had some tags in the getUsedTags() method of 
> the LocationHook ... and found out that these tags are there since the 
> first version of the LocationHook... Just committed that ...
> 
> They are not required because the LocationHook does not depend on any 
> tags in the OSM elements. It only requires tags in the preprocessed 
> boundaries and they don't obey the getUsedTags() convention.
> 
> WanMil
> 
> 
> 
> 
> > sorry, here it is
> >
> > http://gis.638310.n2.nabble.com/file/n7181487/locationHook_speedup_v2.patch
> > locationHook_speedup_v2.patch
> >
> > Gerd
> >
> >
> > WanMil wrote
> >>
> >> Gerd,
> >>
> >> can you please post a patch that is patched against the latest revision
> >> (r2166)?
> >>
> >> Thanks!
> >> WanMil
> >>
> >>> Hi,
> >>>
> >>> attached is a patch that implements LocationHook with a new Quadtree.
> >>> With my test data, it makes mkgmap about 10% faster.
> >>>
> >>> Remarks:
> >>> - Some Nodes and ways are not found. I think that's because they lie
> >>> exactly
> >>> on boundaries. The same problem occurs with mkgmap from trunk. As a work
> >>> around I suggest to search those nodes again with coords decreased by 1.
> >>> - More time may be saved if we manage to save the preprocessed boundary
> >>> data
> >>> in a format that can be directly loaded into the quadtree.
> >>>
> >>> http://gis.638310.n2.nabble.com/file/n7181376/locationHook_speedup.patch
> >>> locationHook_speedup.patch
> >>>
> >>> ciao,
> >>> Gerd
> >>>
> >>> --
> >>> View this message in context:
> >>> http://gis.638310.n2.nabble.com/Patch-v1-LocationHook-with-new-Quadtree-tp7181376p7181376.html
> >>> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> >>> _______________________________________________
> >>> mkgmap-dev mailing list
> >>> mkgmap-dev at .org
> >>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >>
> >> _______________________________________________
> >> mkgmap-dev mailing list
> >> mkgmap-dev at .org
> >> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >>
> >
> >
> > --
> > View this message in context: http://gis.638310.n2.nabble.com/Patch-v1-LocationHook-with-new-Quadtree-tp7181376p7181487.html
> > Sent from the Mkgmap Development mailing list archive at Nabble.com.
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20120112/f938bdff/attachment.html 