[mkgmap-dev] [PATCH] Again NullPointerException

Sat Feb 11 17:17:02 GMT 2012

Hi Thorsten,

I still don't understand. If you enable assertions and you hit one, the program stops and you will have incomplete data.
It makes no sense to use that data or compare sizes.
If you disable assertions, the program should finish (both r2205 and the patched version) and I don't expect different 
file sizes.
I don't understand yet how you can run into the assertion with my patch applied  If your input file is not too big, I like to 
try it. 

Ciao,
Gerd

> Date: Sat, 11 Feb 2012 17:54:47 +0100
> From: kukuk at suse.de
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: Re: [mkgmap-dev] [PATCH] Again NullPointerException
> 
> On Sat, Feb 11, Gerd Petermann wrote:
> 
> > 
> > Hi Thorsten,
> > 
> > I think something must be wrong. I would not expect a change in file sizes and I did not 
> > see one in my test data.
> > The patch verify_boundary_v3.patch doesn't remove any data, so I assume that
> > you have applied one of the older patches.
> > Can you please verify that ?
> > The correct patch contains a line with
> > Collections.reverse(coords); 
> 
> Yes, I only applied the correct patch.
> 
> The only difference between your tests and my I see is, that I run
> into this assert check. Maybe that makes the difference?
> 
>   Thorsten
> 
> > Gerd
> > 
> > 
> > > Date: Sat, 11 Feb 2012 16:49:59 +0100
> > > From: kukuk at suse.de
> > > To: mkgmap-dev at lists.mkgmap.org.uk
> > > Subject: Re: [mkgmap-dev] [PATCH] Again NullPointerException
> > > 
> > > 
> > > Hi,
> > > 
> > > On Thu, Feb 09, GerdP wrote:
> > > 
> > > > Hi,
> > > > 
> > > > as a result of previous discussions here is th new patch.
> > > > 
> > > > http://gis.19327.n5.nabble.com/file/n5471749/verify_boundary_v3.patch
> > > > verify_boundary_v3.patch 
> > > 
> > > With mkgmap-r2205, with and without this patch, I get an expecption
> > > on the planet data from 2012-02-10:
> > > 
> > > Exception in thread "main" java.lang.AssertionError
> > >         at uk.me.parabola.mkgmap.reader.osm.boundary.BoundaryUtil.loadBoundaryFile(BoundaryUtil.java:145)
> > > 
> > > If I disable the assert, mkgmap-r2205 finishes building boundarys
> > > without problems.
> > > 
> > > There is only one big difference in the boundary data:
> > > The boundary data created by mkgmap with this patch is 15% smaller
> > > than the one created without this patch.
> > > 
> > > I don't know how to compare best which data is missing, but I think
> > > 15% is a lot. Or is this expected?
> > > 
> > >   Thorsten
> > > 
> > > -- 
> > > Thorsten Kukuk, Project Manager/Release Manager SLES
> > > SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
> > > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
> > > _______________________________________________
> > > mkgmap-dev mailing list
> > > mkgmap-dev at lists.mkgmap.org.uk
> > > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> >  		 	   		  
> > _______________________________________________
> > mkgmap-dev mailing list
> > mkgmap-dev at lists.mkgmap.org.uk
> > http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> -- 
> Thorsten Kukuk, Project Manager/Release Manager SLES
> SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg)
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20120211/bd06f1ed/attachment.html 