[mkgmap-dev] removeShortArcs_v4.patch for regression in r2448

Sun Feb 3 19:14:30 GMT 2013

Hi Felix,

looks strange. The error occurs at a place which is not touched by the
patch. All that was changed
happens after the evaluation of the style.
Please make sure that you apply it against trunk (r2472) and do an 
ant  clean  

Gerd

Felix Hartmann-2 wrote
> That patch doesn't work for me - mkgmap crashes with:
> 
> java.lang.UnsupportedOperationException
>          at 
> uk.me.parabola.mkgmap.osmstyle.eval.AbstractOp.value(AbstractOp.java:110)
>          at 
> uk.me.parabola.mkgmap.osmstyle.eval.EqualsOp.eval(EqualsOp.java:44)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at uk.me.parabola.mkgmap.osmstyle.eval.AndOp.eval(AndOp.java:34)
>          at 
> uk.me.parabola.mkgmap.osmstyle.ActionRule.resolveType(ActionRule.java:59)
>          at 
> uk.me.parabola.mkgmap.osmstyle.RuleSet.resolveType(RuleSet.java:68)
>          at 
> uk.me.parabola.mkgmap.osmstyle.StyledConverter.convertWay(StyledConverter.java:216)
>          at 
> uk.me.parabola.mkgmap.reader.osm.ElementSaver.convert(ElementSaver.java:237)
>          at 
> uk.me.parabola.mkgmap.reader.osm.bin.OsmBinMapDataSource.load(OsmBinMapDataSource.java:75)
>          at 
> uk.me.parabola.mkgmap.main.MapMaker.loadFromFile(MapMaker.java:144)
>          at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:56)
>          at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:201)
>          at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:198)
>          at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
>          at java.util.concurrent.FutureTask.run(Unknown Source)
>          at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown 
> Source)
>          at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown 
> Source)
>          at java.lang.Thread.run(Unknown Source)
> 
> 
> On 02.02.2013 20:21, GerdP wrote:
>> Hi,
>>
>> I still have no idea what exactly goes wrong, but it seems that we
>> have to apply short arc removal to all ways that are not shapes.
>> Since r2448 this was no longer done, which broke routing.
>>
>> Attached patch for r2473 changes the code so that
>> removeShortArcs is again done for roads and other lines.
>>
>> removeShortArcs_v4.patch
>> &lt;http://gis.19327.n5.nabble.com/file/n5747776/removeShortArcs_v4.patch&gt;
>>
>> Gerd
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://gis.19327.n5.nabble.com/removeShortArcs-v4-patch-for-regression-in-r2448-tp5747776.html
>> Sent from the Mkgmap Development mailing list archive at Nabble.com.
>> _______________________________________________
>> mkgmap-dev mailing list
>> 

> mkgmap-dev at .org

>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> -- 
> keep on biking and discovering new trails
> 
> Felix
> openmtbmap.org & www.velomap.org
> 
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/removeShortArcs-v4-patch-for-regression-in-r2448-tp5747776p5747919.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.