[mkgmap-dev] PATCH v2: hwayCount

Sat Feb 16 20:55:28 GMT 2013

okay I tested the v2.patch.
Routing is pretty similar to without it. But it's not the same. Changes 
are small though. In general I would say in 6 out of 10 times better, in 
4 times worse... (most times quite close though - tested with 
Mapsource/Basecamp, not on GPS). Filesize did decrease a little bit this 
time. (225MB for Austria *.img (without mdr which seems unchanged) vs 
220MB new with patch).
On 15.02.2013 10:57, GerdP wrote:
> Hi Felix,
>
> I think I've found the reason for the problems (increased img size)
>
> Your style file probably contains many continue statements. This leads to
> the following
> situation:
> the same OSM way is added multiple times to the road network.
> For each node of a road, the highway count is increased. For a road that
> appears
> twice or more often, that means that all nodes will become routing nodes,
> not only those nodes that are also used in other streets.
> In the trunk version, this doesn't happen because each way is only counted
> once (but
> also ways that will not be added as roads)
>
> It is easy to fix that problem, but I still have no idea why routing breaks
> with the patch
> (in the default style we don't add roads multiple times)
>
> Attached is the corrected patch.
>
> highwayCount_v2.patch
> <http://gis.19327.n5.nabble.com/file/n5749522/highwayCount_v2.patch>
>
> Gerd
>
>
> Felix Hartmann-2 wrote
>> Smaller?
>>
>> For me my austria map size increased from 295MB to 345MB...
>>
>>
>> Routing over long distances is not working at all anymore (much much
>> worse to before).
>> Don't have time (need to sleep) to find out if any roads become
>> unroutable though...
>> On 07.02.2013 22:25, GerdP wrote:
>>> Hi ,
>>>
>>> attached is a patch that reduces the img size.
>>> Up to now, mkgmap created many so called CoordNodes when
>>> a road and e.g. a building shared an OSM node.
>>> This is not needed and was not intended. As far as I know
>>> it just blows up the size of the img file (typically ~500kb for each
>>> tile).
>>>
>>> The patch reduces the amount of CoordNodes and
>>> also cleans some dead code around the highwayCount.
>>>
>>> Please test if you see  any (new) routing problems with this
>>> patch, I tried quite a while and found none in BaseCamp.
>>>
>>> highwayCount_v1.patch
>>> &lt;http://gis.19327.n5.nabble.com/file/n5748554/highwayCount_v1.patch&gt;
>>>
>>> Gerd
>>>
>>>
>>>
>>> --
>>> View this message in context:
>>> http://gis.19327.n5.nabble.com/PATCH-v1-highwayCount-tp5748554.html
>>> Sent from the Mkgmap Development mailing list archive at Nabble.com.
>>> _______________________________________________
>>> mkgmap-dev mailing list
>>>
>> mkgmap-dev at .org
>>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> -- 
>> keep on biking and discovering new trails
>>
>> Felix
>> openmtbmap.org & www.velomap.org
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> mkgmap-dev at .org
>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
>
>
>
> --
> View this message in context: http://gis.19327.n5.nabble.com/PATCH-v1-highwayCount-tp5748554p5749522.html
> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

-- 
keep on biking and discovering new trails

Felix
openmtbmap.org & www.velomap.org