[mkgmap-dev] [Patch v1] overlaid lines shifted

Thu May 9 07:45:20 BST 2013

Hi all,

I think v1 of the patch is missing a special case:
If the style uses the mkgmap:set_unconnected_type feature
for a road and also creates an overlay line with extended type
for the same OSM way we can have two cases:
1) mkgmap:set_unconnected_type=none
the road is dropped, but the overlay line is not. I think
the overlay line should be dropped as well.
2) mkgmap:set_unconnected_type=<type>
The road is changed to a line. I assume that 
in this case the overlay line should be dropped as
well?

Attached is v2 of the patch to implement that, a compiled binary is here:
http://files.mkgmap.org.uk/download/121/mkgmap.jar

Gerd 
overlayed_lines_v2.patch
<http://gis.19327.n5.nabble.com/file/n5760278/overlayed_lines_v2.patch>  

Felix Hartmann-2 wrote
> thanks Gerd,
> 
> patch is working perfectly (so far as I can tell)...
> On 05.05.2013 03:39, Gerd Petermann wrote:
>> Hi,
>>
>> see first
>> http://gis.19327.n5.nabble.com/merge-lines-and-routing-tp5758913p5759595.html
>>
>> I think the reason is the remove-short-arcs processing. This can move 
>> a road,
>> esp. if you use a rather large value like --remove-short-arcs=5.4. In 
>> the example case, way http://www.openstreetmap.org/browse/way/27904971
>> is moved towards
>> http://www.openstreetmap.org/browse/way/217767494
>>
>> Now, the overlaid line with  type 0x10650 (really this invalid 
>> extended type?)
>> is not a road and stays where it belongs. Another possible effect 
>> would be that the road
>> is deleted while the copy is not.
>> I think the solution is to make sure that
>> 1) all lines created from the same OSM way have the same points after
>> short-arc-removal was done with roads only
>> 2) if short-arc-removal deletes a road (e.g. because it only has one 
>> short arc),the other lines
>> for the same OSM way are deleted as well.
>>
>> Attached is a patch that implements this, a compiled binary is here:
>> |http://files.mkgmap.org.uk/download/120/mkgmap.jar|
>>
>> Gerd
>>
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>> 

> mkgmap-dev at .org

>> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> 
> 
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/Patch-v1-overlaid-lines-shifted-tp5759672p5760278.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.