[mkgmap-dev] Drive-on-left

Tue Aug 13 11:06:05 BST 2013

> Hi
>
>> Btw.: If it's necessary to set --drive-on-left to get everything you
>> need for such a map, then we can remove also the automatism, because
>> everyone will set the param ;)
>
> I'm in favour of removing the guessing. In addition to the problem that
> it might be wrong because of bad data or two countries in the same tile
> (the UK/France is particularly likely), the code is not thread safe and
> so could cause extra tiles to have the wrong flag when used with --max-jobs.
>
> I realise that it probably works 99 times out of a 100 or even more, but
> when it does fail there is no possible warning or clue as to what
> might have happened.
>
> ..Steve
>

Hi Steve,

attached patch forwards the "guessed" drive-on-left value in a thread 
safe way to the NOD header by using a ThreadLocal variable. This is a 
small code change.
Anyhow this makes only sense if you think that the guess algorithm is ok.

WanMil

-------------- next part --------------
A non-text attachment was scrubbed...
Name: dol_threadsafe_v1.patch
Type: application/x-download
Size: 980 bytes
Desc: not available
Url : http://lists.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20130813/15131bbc/attachment.bin 