[mkgmap-dev] Commit: r2707: Don't complete remove an unconnected road.

Fri Oct 4 11:18:18 BST 2013

Hi WanMil,

it probably does, and I think that both are wrong now, but
I like to hear Felix first, as he seems to be the only
one in the list who uses this feature.

In short:
Felix reported an error caused by one of the mergeroads patches
without explicitely mentioning the use of the patch.
Steve posted a fix which was just a work-around, Felix
reported that the fix is ok and Steve committed it to trunk.
In the meantime you created the branch and Felix seemed
to use only that.
In my eyes the trunk version was broken since r2707,
but I got no other feedback.

Gerd

WanMil wrote
> Hi Gerd, hi Felix,
> 
> I haven't following the whole thread. But: The branch should work the 
> same like the trunk. If there are any differences please let me know.
> 
> WanMil
> 
>> oops, sorry, it's vice versa.
>> branch is now 1) and used to be 2)
>>
>> Gerd
>>
>> GerdP wrote
>>> Hi Felix,
>>>
>>> please note that WanMil merged trunk into mergeroads branch.
>>> If I got it right, you should now see overlaying lines
>>> where the road was deleted because of the
>>> mkgmap:set_unconnected_type=none feature.
>>> So, the branch used to be 1) and is now 2).
>>>
>>> Gerd
>>>
>>> GerdP wrote
>>>> Hi Felix,
>>>> Felix Hartmann-2 wrote
>>>>> Note that the "old" behaviour has always been 1). It only changed with
>>>>> the merge-roads patches/branch. At least for revision <2650 this was
>>>>> for
>>>>> sure the case!
>>>> hmm, you never mentioned that you use the patch :-(
>>>> If you find an error in a patch or branch, please make sure
>>>> to mention it.
>>>>
>>>> Now we have a "fixed" trunk version and a branch version that
>>>> doesn't contain the fix posted by Steve. What do you use?
>>>>
>>>> Gerd
>>
> 
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://lists.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/Commit-r2707-Don-t-complete-remove-an-unconnected-road-tp5777740p5780088.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.