[mkgmap-dev] [PATCH] RoadMerger reverses roads

Thu Jan 9 19:33:29 GMT 2014

Hi Gerd,

I will check that.

WanMil

> Hi WanMil,
>
> the patch has an influence on the number of turn restrictions.
> For a tile in northern Germany GPSMapEdit shows :
> r2946 with --x-no-mergeroads: 264 (valid) turn restirictions, 22 invalid
> r2946 with activated mergeroads : 264 (valid) turn restirictions, 22
> invalid
> r2946 with patch and --x-no-mergeroads: 264 (valid) turn restirictions,
> 22 invalid
> r2946 with patch and activated mergeroads : *223* (valid) turn
> restirictions, *25 *invalid
>
> (The invalid turn restrictions are listed in the log. Those are the ones
> that prohibit
> to drive into the wrong end of a oneway road, but GPSMapEdit doesn't
> care when
> the turn restriction also forbids to walk into the road)
>
> Do you think that this could be okay?
>
> Gerd
>
> Date: Wed, 8 Jan 2014 22:55:43 +0100
> From: wmgcnfg at web.de
> To: mkgmap-dev at lists.mkgmap.org.uk
> Subject: [mkgmap-dev] [PATCH] RoadMerger reverses roads
>
> Attached patch improves the RoadMerger so that roads are reversed when
> it is required to be merged with another road.
>
> A small test increased the mergerate by 2% (avg. 17% => 19% road network
> reduction).
>
> Please check it. The p-road check is not yet implemented.
> There are also some performance improvements possible which I will post
> with the next patch version.
> Unit tests may fail.
>
> WanMil
>
>> Hi Gerd,
>>
>>> Hi WanMil,
>>>
>>> two points:
>>> 1) line 517 is obsolete:
>>> mergePoints.add(end);
>>> It just blows up the size of the list and processing time.
>>
>> Yep.
>> I've found another important thing: the road merger can merge many more
>> ways when it reverses non oneway ways. This should be no problem so
>> let's do it :-)
>> I will post another patch.
>
>
>
> _______________________________________________ mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>
>
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev at lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>