[mkgmap-dev] [PATCH v1] Fix handling of housenumbers for street names changed by style

Mon Jun 23 07:14:11 BST 2014

Hi Colin,

If it solves your problem I think it save to commit the patch,at least it
should
do no harm.

@WanMil: I don't fully understand the algos in the HouseNumber* classes
and I don't have time to look at it. 
Can you describe why the ways and nodes which are ignored by the style
are needed for housenumber processing? 
What happens when way 1 and 2 both have name "Abc-street",
the style changes the name to "Abc-Str." and way 2 is ignored by the style?

BTW: If I got that right, the img format allows to store nodes which don't
contain routing info,
but housenumber info. Not important now, as we don't have any code to write
them.

Gerd

Colin Smale wrote
> Hi Gerd, WanMil, 
> 
> Did this patch make it into the "base product"? 
> 
> Colin 
> 
> On 2014-06-03 13:34, GerdP wrote: 
> 
>> Hi Colin,
>> 
>> see http://files.mkgmap.org.uk/download/214/mkgmap.jar [1]
>> 
>> Gerd
>> 
>> Colin Smale wrote
>> This is excellent news! Now I will be able to manipulate abbreviations
>> and suffixes in street names. At the moment I don't have the setup to
>> build the program myself... Could someone provide a jar-file so I can
>> give it a test? Thanks again, Colin On 2014-06-01 13:26, WanMil wrote: Hi
>> Gerd, of course! mkgmap:streetname of roads must match exactly to
>> addr:street of nodes/polygons after style processing. WanMil Hi WanMil,
>> if I got that right, the user has to make sure that a name change is
>> applied to nodes and ways. Correct? Gerd Date: Sun, 1 Jun 2014 12:47:33
>> +0200 From:
> 
>> wmgcnfg@
> 
>> To:
> 
>> mkgmap-dev at .org
> 
>> Subject: [mkgmap-dev] [PATCH v1] Fix handling of housenumbers for street
>> names changed by style The patch changes the house number processing in
>> such a way that it uses OSM elements how they are returned from the style
>> processing. The important thing is that street names of house number
>> nodes are evaluated after style processing and not before. WanMil Hi
>> Gerd, maybe I find some time on the weekend to have a look on it. WanMil
>> Hi Colin, I think you found a bug in the housenumber processing. The
>> current implementation uses the streetnames which exist before style
>> processing to produce a map of existing streets and nodes with addr info.
>> After style processing, It tries to find the nodes and ways with the same
>> name as that of a road. With your changes, this will prob! ably fail. If
>> I got that right, we have to create another map that maps old and new
>> streetnames. @WanMil: Do you have time to look at this? Gerd
>> -------------------------------------------------------------------!
>  -----
> Date: Sun, 25 May 2014 22:18:35 +0200 From:
> 
>> colin.smale@
> 
>> To:
> 
>> mkgmap-dev at .org
> 
>> Subject: [mkgmap-dev] House numbers and styles I have some rules which
>> modify name, addr:street and mkgmap:street in "lines" and "points" which
>> apply some transformations to the street names. The idea is to normalise
>> the names by removing punctuation and standardising abbreviations. The
>> resulting map is missing the house numbers for streets whose name I have
>> modified. In the style rules, I apply identical transformations to the
>> way (looking for highway=* & name=*) and points (looking for addr:street
>> and mkgmap:street, separately of course). I expect that mkgmap can match
>> up the address nodes with the street because the street names are still
>> identical, but something ! is not working right. The modified street name
>> is working fine - that is displayed and is in the index (i.e. I can
>> search for it as a destination). However for these streets only, there
>> don't seem to be any house numbers present. A search for a specific
>> (existing) number on the road finds the road with no num!
>  bers, at
> the centroid of the street. Other streets whose names don't get changed,
> will allow me to find a specific house number and get the location right
> as well. Does anyone have any ideas what might be going wrong here? Am I
> trying to do something that can never work? Is it possible that something
> in the address handling in mkgmap is using the original street name,
> before the style has been applied? Is it possible that the styles don't
> get applied to address-only nodes? I have the following in "lines": # CS:
> normalise by getting rid of . in abbreviations highway=* & name ~
> '.*[.].*' {set name='${name|subst:.-=>-|subst:.~> |subst: +~> }'} ... and
> the following in "points": # ! CS: normalise by getting rid of . in
> abbreviations #mkgmap:street ~ '.*[.].*' {set
> mkgmap:street='${mkgmap:street|subst:.-=>-|subst:.~> |subst: +~> }'; echo
> "fixed mkgmap:street ${mkgmap:street}"} mkgmap:street ~ '.*[.].*' {set
> mkgmap:street='${mkgmap:street|subst:.-=>-|subst:.~> |subst: +~> }'}
> #addr:street ~
> '.*[.].*' {set addr:street='${addr:street|subst:.-=>-|subst:.~> |subst:
> +~> }'; echo "fixed addr:street ${addr:street}"} addr:street ~ '.*[.].*'
> {set addr:street='${addr:street|subst:.-=>-|subst:.~> |subst: +~> }'}
> Thanks in advance for any pointers! Colin
> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2] [1 [2]]
>> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2] [1 [2]]
>> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2] [1 [2]]
>> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2] [1 [2]]
>> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2] [1 [2]]
>> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2] [1 [2]] Links:
>> ------ [1] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2]
>> _______________________________________________ mkgmap-dev mailing list
> 
>> mkgmap-dev at .org
> 
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2]
> 
> --
> View this message in context:
> http://gis.19327.n5.nabble.com/House-numbers-and-styles-tp5807267p5807826.html
> [3]
> Sent from the Mkgmap Development mailing list archive at Nabble.com.
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev [2]
> 
>  
> 
> Links:
> ------
> [1] http://files.mkgmap.org.uk/download/214/mkgmap.jar
> [2] http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
> [3]
> http://gis.19327.n5.nabble.com/House-numbers-and-styles-tp5807267p5807826.html
> _______________________________________________
> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/House-numbers-and-styles-tp5807267p5809238.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.