[mkgmap-dev] Rendering Tunnels

Thu Oct 23 09:35:46 BST 2014

Hi programmers,

attached is a patch.

The problem: mkgmap r3337 doesn't check if a "road" is rendered at level 0.
Because of this missing check it adds the road to the NOD file but doesn't
write it at level 0, which causes broken routing.
I don't know if this is an old error, at least I did not find a change that introduced
it.

The problem is partly caused by the way how we process rules.
Up to now mkgmap sets an internal "road" flag when it finds the road_speed or road_class
attributes within the square brakets. Later it processes the resolution/level information.
Again later it processes the level statement to find out which resolution is placed in what
level. When this is done it is clear whether a given resolution appears at level 0 which
is the only one that is routabable.
On the other hand, some routines simply check the "road" flag to determine if a line is 
a routable way or not using the GType.isRoad() method.

I changed the meaning of isRoad() and added a method hasRoadAttribute() 
which can be used when the old meaning is needed.

Maybe isRoad() should also verify the result of isRoutableLineType()  ?

Gerd

Date: Wed, 22 Oct 2014 21:43:51 +0200
From: eliboni at gmail.com
To: mkgmap-dev at lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] Rendering Tunnels

Gerd thanks for the comment - it's likely a bug in facs: I tried again with same result, 

# WORKING OK 
enrico at gling:/opt/osm/test$ ls -l gmapsupp.img 
-rw-rw-r-- 1 enrico enrico 87724032 ott 22 00:15 gmapsupp.img

#copied lines style file to lines_last adding "road_class=2 road_speed=3"
enrico at gling:/opt/osm/mystyle/r2946/default$ diff lines  lines_last
172c172
< highway=secondary  [0x04 road_class=2 road_speed=3 resolution 20-21 continue]
---
> highway=secondary  [0x04 resolution 20-21 continue]

# ROUTING IS BROKEN
enrico at gling:/opt/osm/test$ ls -l gmapsupp.img 
-rw-rw-r-- 1 enrico enrico 88676352 ott 22 21:30 gmapsupp.img

note that the latter gmapsupp.img with broken routing is 1MB larger than the working one, so it has clearly something more in it while it should not if the routing graph is just the result of res 24 ways...

On Wed, Oct 22, 2014 at 8:37 AM, Gerd Petermann <gpetermann_muenchen at hotmail.com> wrote:

Hi Enrico,

I think this change should NOT have an influence on routing, so it would be an 
error in mkgmap if it does.
Please double check this result.

Gerd

Date: Tue, 21 Oct 2014 23:33:31 +0200
From: eliboni at gmail.com
To: mkgmap-dev at lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] Rendering Tunnels

Dzięki Andrzej! By removing  "road_class=2 road_speed=3" from the 2nd line, routing works and tunnels are visible - here is how it looks line:

highway=secondary & ( network=e-road | int_ref=* ) [0x04 resolution 18-19 continue]
highway=secondary  [0x04 resolution 20-21 continue]
highway=secondary & tunnel=yes [0x11 road_class=2 road_speed=3 resolution 22]
highway=secondary  [0x04 road_class=2 road_speed=3 resolution 22]
All looks fine now, and routable!

Enrico

On Tue, Oct 21, 2014 at 3:30 PM, Andrzej Popowski <popej at poczta.onet.pl> wrote:
Hi Enrico,

> I believe this was my intention: up to res 21 I'd like the line to

> appear as 0x04, from resolution 22 it should appear as 0x11 if a

> tunnel, otherwise 0x04 - no further processing is needed. Could you

> pls let me know why the reasoning is not correct?

This is correct. I have assumed that you'd like to get 2 lines for tunnels: standard road and additional marking for tunnel.

As I understand, routing parameters are only valid for layer 24 (or the last layer in a map). I would remove road_class and road_speed from line:

highway=secondary  [0x04 road_class=2 road_speed=3 resolution 20-21 continue]

Maybe this is the reason for routing errors?

-- 

Best regards,

Andrzej

_______________________________________________

mkgmap-dev mailing list

mkgmap-dev at lists.mkgmap.org.uk

http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  

_______________________________________________

mkgmap-dev mailing list

mkgmap-dev at lists.mkgmap.org.uk

http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141023/73641e1e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isroad-v1.patch
Type: application/octet-stream
Size: 3482 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141023/73641e1e/attachment.obj>