[mkgmap-dev] [Patch v1] check length in substring style function
From Gerd Petermann gpetermann_muenchen at hotmail.com on Tue Dec 16 06:29:50 GMT 2014
Hi all, the discussion about offsets in the mixed-index branch rang a bell: I forgot to answer this post from gbbickerton: "May i suggest that a test is made to check that the string is long enough before applying this filter otherwise an exception occurs .It would be unsafe to use this filter in any style without such a test. " Attached is a small patch that implements these plausibility checks. @gbbickerton: I noticed that you use substring:1:14 which removes the 1st character as counting starts with 0. If nobody complains I'll commit this on thursday. Gerd -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141216/4a353eab/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: Substring_check_v1.patch Type: application/octet-stream Size: 865 bytes Desc: not available URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20141216/4a353eab/attachment.obj>
- Previous message: [mkgmap-dev] Commit: r3374: Latest on the tutorial.
- Next message: [mkgmap-dev] [Patch v1] check length in substring style function
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the mkgmap-dev mailing list