[mkgmap-dev] SVN commit problem

Wed Jan 7 05:50:45 GMT 2015

Hi Mike,

the content of the patch looks ok to me. In the future, please try to use a command like 
svn diff > <path>/xyz.patch
in the mkgmap directory.
to produce one patch file containing all changes that belong together.
The result should look like the attached file.
This allows others to apply it with this simply command:
svn patch > <path>/xyz.patch

It was also agreed that patch files should have unix style line endings
to avoid mixtures. Steve has implemented a hook in svn to check for 
the line endings and files containing dos style are refused.

Gerd

From: mike at tvage.co.uk
To: mkgmap-dev at lists.mkgmap.org.uk
Date: Wed, 7 Jan 2015 00:58:16 +0000
Subject: Re: [mkgmap-dev] SVN commit problem

Hi Gerd, thanks for the quick reply. I'm happy to post patch files for now.
I already posted one suggested change, although I didn't use the create
patch file option.

I have another small patch to improve the message when there are too many
POIS at the same place - two patch files attached.

As the change is only one line of code in each module, I suggest I skip
uploading a binary (I don't have one with only that change in it at
present).

Can I also suggest adding something to the developer web page indicating
that you have to be separately approved before you can upload code changes,
how to apply for approval and the procedure to follow before approval?

Cheers,
Mike

-----Original Message-----
Hi Mike,

I think Steve has to permit that you can commit directly to trunk.
I don't know if you are allowed to create a branch.

If you don't mind, I suggest to use this procedure for now:
1) post a patch file and upload a binary to 
http://files.mkgmap.org.uk/

Let all users know what the patch does and wait for reports.
If we see positive feedback, you may want to 
post a 2nd version to make sure that comments are okay,
unit tests are passed, doc files contain the new feature etc. 
Finally one will commit your change.
If we get the feeling that you know what to do Steve will
probably give you write permits for trunk.

OK?

Gerd

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150107/a34eae45/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xyz.patch
Type: application/octet-stream
Size: 1191 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150107/a34eae45/attachment.obj>