[mkgmap-dev] --make-opposite-cycleways option

Sat Mar 7 08:58:31 GMT 2015

Hi Mike,

I was not able to reproduce a problem with car routing in oneways
using your patch. I see that routes are different when I reverse them
in MapSource.
Please double check and post test data if you still see the problem.

Gerd

From: gpetermann_muenchen at hotmail.com
To: mkgmap-dev at lists.mkgmap.org.uk
Date: Fri, 6 Mar 2015 11:05:27 +0100
Subject: Re: [mkgmap-dev] --make-opposite-cycleways option

Hi Mike,

reg. wrong car routing in oneways: I'll check that, I see no reason now.
Sounds like "continue" is handled like "continue with actions" in this case?

reg. docu for mkgmap:synthesised: yes, please post a patch for that

Gerd

From: mike at tvage.co.uk
To: mkgmap-dev at lists.mkgmap.org.uk
Date: Fri, 6 Mar 2015 09:56:28 +0000
Subject: Re: [mkgmap-dev] --make-opposite-cycleways option

Hi Gerd,  It is possible that the order might have some significance. However, in my own style file I also add the cycleway first and it works fine, providing I do not attempt to start, finish or add a via point to the road. Attempting to start, finish or add a point I can understand might be problematic as the software would not know whether to put the point on the road or the cycleway and may well use the order in which the lines were added. I removed the mkgmap:synthesized line as according to the style manual the value is yes if the way was added by the make-oppositecycleways option, and a check of the code showed that it was the only place it was set. If the updated style file is to replace the make-oppositecycleways option, then this line is no longer required, as it is specific to the cycleway. To retain the functionality, I guess that the additional line should behighway=* & (oneway=yes | oneway=-1 | oneway=true | oneway=1 | oneway=reverse) & (oneway:bicycle=no | cycleway=opposite | cycleway=opposite_lane | cycleway=opposite_track) {delete oneway; delete cycleway; set access=no; delete foot; delete vehicle; delete motor_vehicle; delete motorcar; delete goods; delete hgv; delete psv; delete emergency; delete taxi; delete bus; add bicycle=yes; set highway=cycleway; set mkgmap:synthesised=true} [0x10 road_class=0 road_speed=1 resolution 24 continue]Perhaps the documentation could be enhanced to mention setting mkgmap:synthesised in a style. Regards,Mike From: Gerd Petermann [mailto:gpetermann_muenchen at hotmail.com] 
Sent: 06 March 2015 06:40
To: mkgmap-dev at lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] --make-opposite-cycleways option Hi Mike,Hi Gerd, I added the following to the lines file in my style and it works fine there if I remove the --make-opposite-cycleways option, allowing just cycling and walking against the flow. However, it doesn’t seem to work correctly if I add it to the default style (it allows cars to go the wrong way along the one-way street). highway=* & (oneway=yes | oneway=-1 | oneway=true | oneway=1 | oneway=reverse) & (oneway:bicycle=no | cycleway=opposite | cycleway=opposite_lane | cycleway=opposite_track) {delete oneway; delete cycleway; set access=no; delete foot; delete vehicle; delete motor_vehicle; delete motorcar; delete goods; delete hgv; delete psv; delete emergency; delete taxi; delete bus; add bicycle=yes; set highway=cycleway} [0x10 road_class=0 road_speed=1 resolution 24 continue] I can’t see why this might be happening. Has anyone any ideas (the attached patch is what I changed)?
I think that is the problem I was discussing with Minko. The order in which routable ways are added 
by the style matters, although we don't know exactly why.
With the --make-opposite-cycleways the cycle way is added after the "normal" way,
with your change below it is added before.
Garmin algos seem to use only one way in some cases, esp. at the beginning of a route.

Further thoughts: 
1) Your new patch also removes the special handling for mkgmap:synthesised in inc/access
-#limit artificial cycleways to to resolution 24
-mkgmap:synthesised=yes & mkgmap:bicycle=yes { set mkgmap:highest-resolution-only = true }
This is okay for your case, but I should mention that the tag
mkgmap:synthesised is also evaluated within mkgmap to avoid some
meaningless warnings in e.g. the roundabout checks.
In other words: A style that adds  multiple routable ways for one OSM way
should try to  setmkgmap:synthesised=true 
when options like --check-roundabouts or --check-roundabout-flares are used.

I think we might as well set that a corresponding flag in mkgmap when it detects 
that more than one routable way was added (with res 24) for one OSM way.

2) Maybe we can replace the  --make-opposite-cycleways option by 
a new special tag like mkgmap:add_cycleway=[before|after] ?

Gerd

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150307/ce42cf4b/attachment-0001.html>