[mkgmap-dev] Commit: r3573: admin_centre-v1.patch: avoid to create duplicate POI

Wed May 13 10:35:36 BST 2015

Hi Gerd,

There is something weird happening with this version r3573, maybe a bug or maybe a fault in my styles?
The name of London disappears and becomes England, http://www.openstreetmap.org/relation/58447  
I see the same for Edinburgh which becomes Scotland. 
Any idea what went wrong here? How can I get the name of England not at the node of London (=admin_centre) but in the middle of the country / relation? With mkgmap-r3487 it was still ok.

See http://mijndev.openstreetmap.nl/~ligfietser/test/ for my styles and the tiles around London.

> Version mkgmap-r3573 was committed by gerd on Sun, 10 May 2015
> 
> admin_centre-v1.patch: avoid to create duplicate POI
> 
> It implements the following:
> When POIGeneratorHook creates a POI for a type=boundary relation
> with boundary=administrative it searches for a role=admin_centre member
> in that relation.
> If one is found, the generated POI will use the coordinates of this member.
> 
> I see no easy way to compare the tags of the existing
> node with those of the generated POI, so
> as a second step, StyledConverter detects when a POI
> with the same type and name (or empty name) is created at the
> same Garmin coordinates (after style processing)
> If that is true, the latter one is ignored and an info message is logged.
> 
> Maybe for certain types this should be changed to check for a radius
> rather than equality, but that would require complex configuration.