[mkgmap-dev] [Patch v2] use role=label member to place POI

Thu May 21 14:26:23 BST 2015

Hi Marcio,

I am not sure if I undersstand all arguments correctly, but I think
the patch implements what you want. Please try it and let me
know when you find problems.

Gerd

From: thundercel at gpsinfo.com.br
To: mkgmap-dev at lists.mkgmap.org.uk
Date: Thu, 21 May 2015 09:44:48 -0300
Subject: Re: [mkgmap-dev] [Patch v2] use role=label member to place POI

Hi Gerd,
our proposal is 
to always use the label node when that is 
present, to put the POI generated for admin_level = 10 limit when there

I do not know in other countries, but in Brazil we have the administration suburb figure and usually that's where we put the label node.

I did 
not understand your concern 
that node can also be used for different relations because we are 
dealing solely the boundary relationship, however, even being employed by other relations do not see problems because it is defined by the tag name and is 
in its correct position.

Particularly not identify employment status of that node when the tag name is missing and also can not 
identify situation in which an unnamed relationship can hire a node also unnamed. I say this because 
we are referring to node similar to that name in any relations that the employed.

Marcio 

From: Gerd Petermann 
Sent: Thursday, May 21, 2015 4:30 AM
To: mkgmap-dev at lists.mkgmap.org.uk 

Subject: [mkgmap-dev] [Patch v2] use role=label member to place 
POI

Hi all,

sorry, v1 was missing a check for null , attached is 
v2, the binary is here:
http://files.mkgmap.org.uk/download/269/mkgmap.jar

To 
ease testing I've added a log message with error level ,e.g. 

...  using label node as location for 
POI for rel 334443 Goiás at -15.933471/-50.140561

it will also complain loudly when 
the node is not used because the names don't match:
... rel 
http://www.openstreetmap.org/relation/331515 ,node with role label is ignored 
because it has a different name

Please suggest better text for the 
messages.
These messages show were the patch changes something, it will be 

changed to debug/warn level before committing the patch.

If I got 
that right, Marcio and Anor propose to always use the label node
to place the 
generated POI for admin_level=10 boundaries,  
but I see one potential 
problem here:
The node might also be used by different relations, and in that 
case
we will produce different POI at the same location.
I think this is 
something we want to avoid.

One more point I am not sure about:
The 
node in the mp-relation is only used when both the relation and the node have a 
name tag
(or whatever the name-tag-list tells mkgmap to use as name), 
and 
when these are equal.
Do you see a case where we should use the node even if 
one of the name tags is 
missing?

Gerd

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150521/9ff3a040/attachment.html>