logo separator

[mkgmap-dev] [Patch v2] sharp angles

From Gerd Petermann gpetermann_muenchen at hotmail.com on Thu Sep 3 09:51:13 BST 2015

Hi Felix,

okay, I'll try to reproduce it.

Gerd

Subject: Re: [mkgmap-dev] [Patch v2] sharp angles
To: gpetermann_muenchen at hotmail.com
From: extremecarver at gmail.com
Date: Thu, 3 Sep 2015 10:45:05 +0200


  
    
  
  
    

    

    On 03.09.2015 10:43, Gerd Petermann
      wrote:

    
    
      
      Hi Felix,

        

        great!

        Do you have the log (created with
        me.parabola.imgfmt.app.net.AngleChecker.level=INFO

        in logging.properties)

        for this point and the one where the u-turn happens?

      
    
    Nope - did not use that.

    
      

        Does it also happen when you chose points which are not on the
        road

        but close to it?

      
    
    yes. Does not seem to matter.

    
      

        Gerd

        

        

        
          Date: Thu, 3 Sep 2015 10:25:50 +0200

          Subject: Re: [mkgmap-dev] [Patch v2] sharp angles

          From: extremecarver at gmail.com

          To: mkgmap-dev at lists.mkgmap.org.uk;
          gpetermann_muenchen at hotmail.com

          

          
            
              
                
                  
                    
                      
                        Hi Gerd - okay now with patched and
                          removing --adjust-turn-headinfs - plus adding
                          both options I can see (vs before with
                          adjust-turns-headings)

                        
                        a) improvements on some tight turns (though not
                        all tight turns)

                      
                      b) less of those errors (though some still exist -
                      but much less)

                    
                    c) less erroneous detours on longer routes

                  
                  d) valid only for Car/Motorcycle routing - often on
                  the same route shorter times - sometimes longer as
                  well though. The other profiles are much less affected
                  here.

                  

                
                e) no difference at all in the maximum routable
                distance.

                

                

              
              Once a strange degradation (again same place as
              yesterday):

            
            Routing is alway correct on old map - but times are much
            slower. Old map nearly always had 1min

            
              

                

              
              Only on Driving profile this bug happens (but no
                other - even Motorcycle is fine). Still 1min. However
                all other profiles (except walking) are between
                26-28seconds.

                

                

                

              
              Overall I would say it's a clear improvement (but
                yeah - those additional ways I guess would still be
                better).

              
              

                

                

              
            
          
          

            On 3 September 2015 at 08:43,
              Gerd Petermann <gpetermann_muenchen at hotmail.com>
              wrote:

              
                
                  Hi Felix,

                    

                    if you get the same differences with the unpatched
                    version and 

                    --adjust-turn-headings turned on/off I see no
                    miracles.

                    

                    Gerd

                    

                    
                      Date: Thu, 3 Sep 2015 08:21:43 +0200
                      
                        

                          From: extremecarver at gmail.com

                          To: mkgmap-dev at lists.mkgmap.org.uk

                          Subject: Re: [mkgmap-dev] [Patch v2] sharp
                          angles

                          

                          
                            
                              Ah - thanks. Well too strange I still
                                got some differences... 

                              
                              I did not know and wondered why I found so
                              little difference. 

                              

                            
                            So more results in 1-3 hours - back to
                            testing now.

                          
                          

                            On 3 September 2015 at 07:03, Gerd
                              Petermann <gpetermann_muenchen at hotmail.com>
                              wrote:

                              
                                
                                  Hi Felix,

                                    

                                    got your mail with the pictures.

                                    Please check:

                                    You wrote that you used 
                                    --x-cycle-map, but you did not
                                    mention 

                                    --x-fix-sharp-angles. I was probably
                                    not clear about these options.

                                    

                                    If you did not also use
                                    --x-fix-sharp-angles you measured
                                    the effect

                                    of the removal of the
                                    --adjust-turn-headings option, as
                                    --x-cycle-map

                                    on it own has no effect with the
                                    patch.

                                    

                                    Reg. testing: Please try to route to
                                    points close to but not on the road.

                                    Maybe this avoids the u-turns when
                                    the Garmin algo reaches the target

                                    on the "right" road (but "wrong"
                                    arc) and adds a u-turn to get on the
                                    road 

                                    arc that was selected as target.

                                    

                                    Gerd

                                    

                                    

                                    

                                    

                                    
                                      Date: Wed, 2 Sep 2015 21:40:34
                                      +0200

                                      From: extremecarver at gmail.com

                                      To: mkgmap-dev at lists.mkgmap.org.uk

                                      Subject: Re: [mkgmap-dev] [Patch
                                      v2] sharp angles
                                      
                                        

                                          

                                          
                                            
                                              Well - I used 

                                                --x-cycle-map

                                                

                                              
                                              but for some intersections
                                              it would still not work.
                                              In 4 out of 10 long
                                              distance routing examples
                                              I tried in Basecamp - the
                                              result was better. In 4 it
                                              was the same, and in 2 it
                                              was slightly worse. 

                                            
                                            So overall it is a modest
                                            improvement - but I would
                                            have hoped for a bit more.
                                            Still - clearly and
                                            improvement.

                                          
                                          

                                            On 29 August 2015 at
                                              23:11, Felix Hartmann <extremecarver at gmail.com>
                                              wrote:

                                              
                                                Sorry - I
                                                  was on an enduro MTB
                                                  Race for the last week
                                                  - I will start testing
                                                  on Tuesday...

                                                
                                                
                                                  
                                                    

                                                      On 28 August
                                                        2015 at 17:34,
                                                        Gerd Petermann <gpetermann_muenchen at hotmail.com>
                                                        wrote:

                                                        
                                                          
                                                          

                                                          oops. the link
                                                          for the binary
                                                          was missing:

                                                          http://files.mkgmap.org.uk/download/280/mkgmap.jar

                                                          

                                                          Gerd

                                                          
                                                          
                                                          From: gpetermann_muenchen at hotmail.com

                                                          To: mkgmap-dev at lists.mkgmap.org.uk

                                                          Date: Fri, 28
                                                          Aug 2015
                                                          17:33:39 +0200

                                                          Subject:
                                                          [mkgmap-dev]
                                                          [Patch v2]
                                                          sharp angles
                                                          
                                                          

                                                          

                                                          Hi
                                                          all, 

                                                          

                                                          attached is v2
                                                          of the patch,
                                                          the binary is
                                                          here:

                                                          

                                                          

                                                          Correction:
                                                          the previous
                                                          versions did
                                                          not change
                                                          angles like 
                                                          this: /\

                                                          Improvement:
                                                          For bicycle
                                                          maps, the
                                                          angle is
                                                          changed up to
                                                          90° for arcs 

                                                          with high road
                                                          speeds.

                                                          

                                                          Options
                                                          (--x-fix-sharp-angles 
                                                          and
                                                          --x-cycle-map)
                                                          are the same.

                                                          

                                                          @Felix: I wait
                                                          for your
                                                          feedback now,
                                                          as I have no
                                                          way to test
                                                          with your
                                                          style.

                                                          

                                                          Gerd

                                                          

                                                          

                                                          

                                                          

                                                          
                                                          

                                                          
                                                          
                                                          _______________________________________________
mkgmap-dev
                                                          mailing list
                                                          mkgmap-dev at lists.mkgmap.org.uk
                                                          http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
                                                          
                                                          
                                                          

_______________________________________________

                                                          mkgmap-dev
                                                          mailing list

                                                          mkgmap-dev at lists.mkgmap.org.uk

                                                          http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

                                                        
                                                      
                                                      

                                                      
                                                      

                                                    
                                                  
                                                  --
                                                      

                                                      
                                                        
                                                          
                                                          
                                                          Felix
                                                          Hartman -
                                                          Openmtbmap.org
                                                          &
                                                          VeloMap.org

                                                          
                                                          Floragasse
                                                          9/11

                                                          
                                                          1040 Wien

                                                          
                                                          Austria -
                                                          Österreich
                                                      
                                                    
                                              
                                            
                                            

                                            
                                            

                                            -- 

                                            
                                              
                                                
                                                  
                                                    Felix Hartman -
                                                      Openmtbmap.org
                                                      & VeloMap.org

                                                    
                                                    Floragasse 9/11

                                                  
                                                  1040 Wien

                                                
                                                Austria - Österreich
                                            
                                          
                                          

                                          _______________________________________________
mkgmap-dev
                                          mailing list
                                          mkgmap-dev at lists.mkgmap.org.uk
                                          http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
                                      
                                    
                                  
                                
                                

_______________________________________________

                                mkgmap-dev mailing list

                                mkgmap-dev at lists.mkgmap.org.uk

                                http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

                              
                            
                            

                            
                            

                            -- 

                            
                              
                                
                                  
                                    Felix Hartman - Openmtbmap.org
                                      & VeloMap.org

                                    
                                    Floragasse 9/11

                                  
                                  1040 Wien

                                
                                Austria - Österreich
                            
                          
                          

                          _______________________________________________
mkgmap-dev
                          mailing list
                          mkgmap-dev at lists.mkgmap.org.uk
                          http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
                      
                    
                  
                
                

                _______________________________________________

                mkgmap-dev mailing list

                mkgmap-dev at lists.mkgmap.org.uk

                http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

              
            
            

            
            

            -- 

            
              
                
                  
                    Felix Hartman - Openmtbmap.org &
                      VeloMap.org

                    
                    Floragasse 9/11

                  
                  1040 Wien

                
                Austria - Österreich
            
          
        
      
    
    

    -- 
keep on biking and discovering new trails

Felix
openmtbmap.org & www.velomap.org 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150903/ab8182c8/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ATT00001
Type: image/png
Size: 16754 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150903/ab8182c8/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ATT00002
Type: image/png
Size: 12824 bytes
Desc: not available
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150903/ab8182c8/attachment-0003.png>


More information about the mkgmap-dev mailing list