[mkgmap-dev] [patch] add support for information=guidepost POI in default style

Thu Sep 17 08:43:34 BST 2015

Hi Ben,

sorry for the delay, I was biking for a few days. 
I had small problems with your patch because it seems not to be based on the svn 
version, so please double check the changes.

Gerd

Date: Tue, 8 Sep 2015 16:25:46 +0200
From: ben at bagu.org
To: mkgmap-dev at lists.mkgmap.org.uk
Subject: Re: [mkgmap-dev] [patch] add support for information=guidepost POI in default style

Hi Gerd,

I've attached a new patch with the previously mentioned change. I've also changed the other POI using 0x2f0c to 'amenity=toilets & highway=rest_area' which seems to match the POI type better.

Thanks, Ben

On Tue, Sep 8, 2015 at 3:49 PM, Ben Konrath <ben at bagu.org> wrote:
Hi Gerd,

I didn't spend too much time digging into this but I agree that it makes sense to solve this correctly.

According to this XLS file with Garmin POIs, 0x2f0c is for Toilets and will be listed in the the Auto Services -> Rest Area / Tourist Info category. 

http://www.cferrero.net/maps/downloads/garmin_feature_list.xls

> 0x2F0C    Toilet    Blue, small    Auto Services    Rest Area / Tourist Info     Yes    Restroom

According to the osm tag page, tourism=information is for information sources, not toilets.

https://wiki.openstreetmap.org/wiki/Tag:tourism%3Dinformation

I propose that we just change tourism=information to 0x4c00 regardless of the the information=* refinement and ignore the previous patch.

tourism=information [0x4c00 resolution 24]

What do you think?

Thanks, Ben

On Tue, Sep 8, 2015 at 2:48 PM, GerdP <gpetermann_muenchen at hotmail.com> wrote:
Hi Ben,

the node in your example has the tag tourism=information

and the default style contains the rule.

tourism=information [0x2f0c resolution 24]

Your patch adds the rule

information=guidepost [0x4c00 resolution 24]

I'd prefer to modify the existing rule,

but I don't know which of the types is more

likely to show the wanted icon.

Gerd

Ben Konrath wrote

> Hi,

>

> The default style currently has information=guidepost POIs set as a toilet

> icon. This patch changes information=guidepost to be an 'i' in a circle.

> For reference, here's an example of a POI with this tag:

>

> https://www.openstreetmap.org/node/2883638464

>

> Thanks, Ben

>

> _______________________________________________

> mkgmap-dev mailing list

> mkgmap-dev at .org

> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

>

> mkgmap-add-support-for-information-guidepost.patch (746 bytes)

> <http://gis.19327.n5.nabble.com/attachment/5854217/0/mkgmap-add-support-for-information-guidepost.patch>

--

View this message in context: http://gis.19327.n5.nabble.com/patch-add-support-for-information-guidepost-POI-in-default-style-tp5854217p5854227.html

Sent from the Mkgmap Development mailing list archive at Nabble.com.

_______________________________________________

mkgmap-dev mailing list

mkgmap-dev at lists.mkgmap.org.uk

http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20150917/3a1926b4/attachment.html>