[mkgmap-dev] feedback on sharp-angles-v4.patch?

Tue Oct 27 06:51:43 GMT 2015

Hi all,

okay, it took a while because I am busy cleaning up wrong highways...

My thinking was this:
1) We want to enlarge sharp angles because we know that a cyclist 
doesn't care that much about them and typically they are not as sharp
in reality.
2) I don't want to enlarge sharp angles at junctions which are only used by
cars, esp. I don't want to introduce time penalties at motorway junctions
and I don't want to remove time penalties at junctions where a turn
restriction
is missing and the Garmin algo avoids routing through the sharp angle.
3) The --cycle-map option allows to ignore the problem cases in 2)
and (with v4) it also allows to enlarge the angles even more.

I guess that this later part is not a good idea, so I've commented that
part of the code and changed the documentation of the option a little bit.

See also svn log for r3649.

Gerd

GerdP wrote
> Hi all,
> 
> sorry, forgot the more important effect of this option:
> With --cycle-map you can tell mkgmap that different
> vehicles like car, truck are used as replacements for
> racing bike, mtb, normal bike or whatever.
> 
> I'll review that part again as it doesn't seem to work 
> as expected.
> 
> Gerd
> 
> GerdP wrote
>> Hi Minko,
>> 
>> if you can't find any, that is also telling me that the option is rather
>> useless.
>> 
>> With --cycle-map mkgmap might produce larger changes when the 
>> sum of the road_speed values of two arcs is rather high.
>> 
>> The corresponding part of the patch:
>> +			if (cycleMap){
>> +//				if (sumSpeeds >= 14)
>> +//					maskedMinAngle = 0x80;
>> +//				if (sumSpeeds >= 12)
>> +//					maskedMinAngle = 0x70;
>> +//				if (sumSpeeds >= 10)
>> +//					maskedMinAngle = 0x60;
>> +				if (sumSpeeds >= 8)
>> +					maskedMinAngle = 0x50;
>> +				else if (sumSpeeds >= 6)
>> +					maskedMinAngle = 0x40;
>> +				else if (sumSpeeds >= 4)
>> +					maskedMinAngle = 0x30;
>> +			}
>> 
>> Does that help?
>> 
>> Gerd 
>> ________________________________________
>> Von: 

>> mkgmap-dev-bounces at .org

>>  &lt;

>> mkgmap-dev-bounces at .org

>> &gt; im Auftrag von Minko &lt;

>> ligfietser@

>> &gt;
>> Gesendet: Samstag, 17. Oktober 2015 15:17
>> An: Development list for mkgmap
>> Betreff: Re: [mkgmap-dev] feedback on sharp-angles-v4.patch?
>> 
>> I have tested it with --cycle-map
>> What is the difference vs without this option?
>> 
>> _______________________________________________
>> mkgmap-dev mailing list

>> mkgmap-dev at .org

>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>> _______________________________________________
>> mkgmap-dev mailing list

>> mkgmap-dev at .org

>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

--
View this message in context: http://gis.19327.n5.nabble.com/feedback-on-sharp-angles-v4-patch-tp5856851p5857988.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.