[mkgmap-dev] Assertion building Italy map

Sun Feb 7 19:19:07 GMT 2016

I can't remember when and why it was that I added that line to my style. 
I have removed it and result seems better regarding inner members and 
routing.

El 07/02/16 a las 16:53, Gerd Petermann escribió:
> Hi Carlos,
>
> I just tried to implement that and found out that I was wrong, the tags are not added by the MP-code.
> It is this rule in your relations file:
> highway=pedestrian & area=yes {apply {add highway=pedestrian; add area=yes; add name='${name}' } }
>
> I am not sure if it possible to change that rule so that it only changes outer member of type=multipolygon rels ?
> On the other hand I think that this is already done by the MP-Code in  mkgmap, so maybe just remove the rule.
>
> Gerd
>
> ________________________________________
> Von: mkgmap-dev-bounces at lists.mkgmap.org.uk <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <cdavilam at orangecorreo.es>
> Gesendet: Sonntag, 7. Februar 2016 11:51
> An: Development list for mkgmap
> Betreff: Re: [mkgmap-dev] Assertion building Italy map
>
> I agree inner members of the relation should not be added as roads, but
> AFAIK rules included in relations file are applied to all relation
> members. Your suggestion of mkgmap:mp_role tag could provide a better
> handling of such cases.
>
> El 05/02/16 a las 10:04, Gerd Petermann escribió:
>> Hi Carlos,
>>
>> my concern reg. routing is that your style probably should not add the role=inner
>> elements as roads. I think Andrzej suggested to use a rule like
>> mkgmap:mp_created=true {set area=yes}
>> but that would not help in your case. Maybe the Multipolygon Code should add another
>> tag for the calculated role of the generated way, e.g.
>> mkgmap:mp_role=inner   or =outer
>>
>> Gerd
>>
>> ________________________________________
>> Von: mkgmap-dev-bounces at lists.mkgmap.org.uk <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <cdavilam at orangecorreo.es>
>> Gesendet: Donnerstag, 4. Februar 2016 22:14
>> An: Development list for mkgmap
>> Betreff: Re: [mkgmap-dev] Assertion building Italy map
>>
>> Thank you very much for the quick fix Gerd
>> I'll try to check routing tomorrow and report back in case of trouble.
>>
>> El 04/02/16 a las 21:24, Gerd Petermann escribió:
>>> Hi Carlos,
>>>
>>> thanks for the data. Quite a special case. The problem is caused by this way:
>>> https://www.openstreetmap.org/way/393470425
>>>
>>> It is an inner member of a mp-relation  which your style adds as a road.
>>> Therefore all the inner elements are also added as roads, and this building is so small
>>> that all points are rounded to three equal Garmin points.
>>> As this way is also a closed loop the code tries to split it and removes equal points,
>>> in the end the way remained with just one point and that way was not discarded.
>>> I've added a check to detect this special case with r3664.
>>>
>>> I did not try if routing works now at this place.
>>>
>>> ciao,
>>> Gerd
>>>
>>>
>>> ________________________________________
>>> Von: mkgmap-dev-bounces at lists.mkgmap.org.uk <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Carlos Dávila <cdavilam at orangecorreo.es>
>>> Gesendet: Donnerstag, 4. Februar 2016 17:41
>>> An: Development list for mkgmap
>>> Betreff: [mkgmap-dev] Assertion building Italy map
>>>
>>> I'm getting the following error building Italy map with latest version
>>> of mkgmap and my own style:
>>> |java.lang.AssertionError: failed for node 66008 at 40.842415,14.246541||
>>> ||        at
>>> uk.me.parabola.imgfmt.app.net.RouteNode.getOffsetNod1(RouteNode.java:273)||
>>> ||        at
>>> uk.me.parabola.imgfmt.app.net.RoadDef.writeNod2(RoadDef.java:579)||
>>> ||        at
>>> uk.me.parabola.imgfmt.app.net.NODFile.writeRoadData(NODFile.java:125)||
>>> ||        at uk.me.parabola.imgfmt.app.net.NODFile.write(NODFile.java:73)||
>>> ||        at
>>> uk.me.parabola.mkgmap.build.MapBuilder.makeMap(MapBuilder.java:251)||
>>> ||        at
>>> uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:107)||
>>> ||        at uk.me.parabola.mkgmap.main.MapMaker.makeMap(MapMaker.java:69)||
>>> ||        at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:255)||
>>> ||        at uk.me.parabola.mkgmap.main.Main$1.call(Main.java:251)||
>>> ||        at java.util.concurrent.FutureTask.run(FutureTask.java:262)||
>>> ||        at
>>> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)||
>>> ||        at
>>> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)||
>>> ||        at java.lang.Thread.run(Thread.java:724)|
>>> Default style works fine with the same input files. What info/file about
>>> my style would you need to trackr the error?
>>> My command:
>>> java -Xmx4500m -ea -Dlog.config=logging.properties -jar mkgmap.jar
>>> --output-dir=./tmp --bounds=bounds.zip --precomp-sea=sea.zip --max-jobs
>>> --route --latin1 --code-page=1252 --country-name=$PAIS
>>> --country-abbr=$ABR --area-name=$MAPA --family-name="OpenStreetMap
>>> $MAPA" --family-id=1$FID --product-id=1 --series-name="OSM-$MAPA"
>>> --overview-mapname=$ABR-1$FID --overview-mapnumber=551${FID}000
>>> --name-tag-list=$NAMETAG --index --process-destination --process-exits
>>> --housenumbers --reduce-point-density=4 --polygon-size-limits="24:12,
>>> 18:10, 16:0" --add-pois-to-areas --report-similar-arcs
>>> --report-dead-ends=2 --link-pois-to-ways
>>> --location-autofill=is_in,nearest --drive-on=detect,$DRIVEON
>>> --check-roundabouts --check-roundabout-flares
>>> --license-file=license_ODbL.txt --copyright-message="OpenStreetMap
>>> contributors, ODbL. See: http://www.openstreetmap.org/copyright"
>>> --style=mio --check-styles -c $pais.args
>>>
>>>
>>