[mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message

Sat Jan 21 06:09:07 GMT 2017

Hi Mike,

thanks for reporting. No idea how this bug passed my tests.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Mike Baggaley <mike at tvage.co.uk>
Gesendet: Freitag, 20. Januar 2017 22:31:46
An: 'Development list for mkgmap'
Betreff: Re: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many    POIs at location" error message

HI Gerd, since r3756, I am getting an index out of bounds crash in uk.me.parabola.mkgmap.build.MapArea.distPointsEqually() at the line containing
                                extraArea.addPoint(this.points.get(done + j));

There are two loops affecting done and j, but the inner loop doesn't appear to check that done + j is less than points.size().

I could just add a test to the inner loop, but am not sure whether there are any side effects of doing this.

Can you take a look?

I assume whatever the fix is, it will also need applying to distLinesEqually().

Thanks,
Mike

-----Original Message-----
From: svn commit [mailto:svn at mkgmap.org.uk]
Sent: 16 January 2017 15:41
To: mkgmap-svn at lists.mkgmap.org.uk; mkgmap-dev at lists.mkgmap.org.uk
Subject: [mkgmap-dev] Commit r3756: improve MapSplitter: avoid "Too many POIs at location" error message

Version mkgmap-r3756 was committed by gerd on Mon, 16 Jan 2017

improve MapSplitter: avoid "Too many POIs at location" error message

http://www.mkgmap.org.uk/websvn/revision.php?repname=mkgmap&rev=3756

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev