[mkgmap-dev] Is height: filter working as described?

Fri Feb 3 10:37:35 GMT 2017

Hi all,

it is quite easy to implement the support for comma as optional decimal separator, but
much more difficult to produce a reasonable warning. The problem is that the routine
which detects the error may be called several times when style rules are evaluated.
Attached is a patch which creates a warning for each evaluation.
With the default style the messages look like this:
WARN: uk.me.parabola.mkgmap.osmstyle.actions.ConvertFilter  f:\osm\peaks.osm: invalid decimal separator found in value '13,3' http://www.openstreetmap.org/node/-31655
WARN: uk.me.parabola.mkgmap.osmstyle.actions.ConvertFilter  f:\osm\peaks.osm: invalid decimal separator found in value '13,3' http://www.openstreetmap.org/node/-31655
WARN: uk.me.parabola.mkgmap.osmstyle.actions.ConvertFilter  f:\osm\peaks.osm: invalid decimal separator found in value '13,3m' http://www.openstreetmap.org/node/-31660
WARN: uk.me.parabola.mkgmap.osmstyle.actions.ConvertFilter  f:\osm\peaks.osm: invalid decimal separator found in value '13,3m' http://www.openstreetmap.org/node/-31660

The corresponding OSM file is attached, a binary with the patch is here:
 http://files.mkgmap.org.uk/download/332/mkgmap.jar

@Steve: Please check the change in the regex pattern, I think the dot in the existing pattern should be quoted ?

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-bounces at lists.mkgmap.org.uk> im Auftrag von Andrzej Popowski <popej at poczta.onet.pl>
Gesendet: Donnerstag, 2. Februar 2017 16:38:37
An: mkgmap-dev at lists.mkgmap.org.uk
Betreff: Re: [mkgmap-dev] Is height: filter working as described?

Hi Carlos,

maybe mkgmap could issue a warning for filter whenever input data are
not compatible? Comma is a standard decimal separator in Poland and
there is a lot of erroneous tags. I haven't noticed this problem until now.

When numeric value contains a comma, filter "height" doesn't convert tag
value but adds a a separator. The result is that Mapsource doesn't
display label at all.

--
Best regards

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev at lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: decimal_sep.patch
Type: application/x-download
Size: 1821 bytes
Desc: decimal_sep.patch
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20170203/d2812c51/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: peaks.osm
Type: application/octet-stream
Size: 777 bytes
Desc: peaks.osm
URL: <http://www.mkgmap.org.uk/pipermail/mkgmap-dev/attachments/20170203/d2812c51/attachment.obj>